fbobjc

jeffmo · facebook-github-bot · commit 59257d697665 · 2017-03-04T19:30:34.000-08:00
Reviewed By: gabelevi

Differential Revision: D4652687

fbshipit-source-id: 6069c8bc24f0b88da3537ada877cdb7d1d4eccfd
diff --git a/.flowconfig b/.flowconfig
@@ -41,12 +41,12 @@ suppress_type=$FlowIssue
 suppress_type=$FlowFixMe
 suppress_type=$FixMe
 
-suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(4[0-0]\\|[1-3][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native_oss[a-z,_]*\\)?)\\)
-suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(4[0-0]\\|[1-3][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native_oss[a-z,_]*\\)?)\\)?:? #[0-9]+
+suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(4[0-1]\\|[1-3][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native_oss[a-z,_]*\\)?)\\)
+suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(4[0-1]\\|[1-3][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native_oss[a-z,_]*\\)?)\\)?:? #[0-9]+
 suppress_comment=\\(.\\|\n\\)*\\$FlowFixedInNextDeploy
 suppress_comment=\\(.\\|\n\\)*\\$FlowExpectedError
 
 unsafe.enable_getters_and_setters=true
 
 [version]
-^0.40.0
+^0.41.0
diff --git a/Examples/UIExplorer/js/CameraRollView.js b/Examples/UIExplorer/js/CameraRollView.js
@@ -81,6 +81,7 @@ var propTypes = {
 };
 
 var CameraRollView = React.createClass({
+  // $FlowFixMe(>=0.41.0)
   propTypes: propTypes,
 
   getDefaultProps: function(): Object {
@@ -123,6 +124,7 @@ var CameraRollView = React.createClass({
   rendererChanged: function() {
     var ds = new ListView.DataSource({rowHasChanged: this._rowHasChanged});
     this.state.dataSource = ds.cloneWithRows(
+      // $FlowFixMe(>=0.41.0)
       groupByEveryN(this.state.assets, this.props.imagesPerRow)
     );
   },
@@ -209,6 +211,7 @@ var CameraRollView = React.createClass({
       if (image === null) {
         return null;
       }
+      // $FlowFixMe(>=0.41.0)
       return this.props.renderImage(image);
     });
 
@@ -231,6 +234,7 @@ var CameraRollView = React.createClass({
       newState.lastCursor = data.page_info.end_cursor;
       newState.assets = this.state.assets.concat(assets);
       newState.dataSource = this.state.dataSource.cloneWithRows(
+        // $FlowFixMe(>=0.41.0)
         groupByEveryN(newState.assets, this.props.imagesPerRow)
       );
     }
diff --git a/Libraries/CameraRoll/CameraRoll.js b/Libraries/CameraRoll/CameraRoll.js
@@ -81,6 +81,7 @@ var getPhotosParamChecker = createStrictShapeTypeChecker({
  * Shape of the return value of the `getPhotos` function.
  */
 var getPhotosReturnChecker = createStrictShapeTypeChecker({
+  // $FlowFixMe(>=0.41.0)
   edges: ReactPropTypes.arrayOf(createStrictShapeTypeChecker({
     node: createStrictShapeTypeChecker({
       type: ReactPropTypes.string.isRequired,
diff --git a/Libraries/Components/DatePicker/DatePickerIOS.ios.js b/Libraries/Components/DatePicker/DatePickerIOS.ios.js
@@ -35,6 +35,7 @@ type Event = Object;
  * the user's change will be reverted immediately to reflect `props.date` as the
  * source of truth.
  */
+// $FlowFixMe(>=0.41.0)
 const DatePickerIOS = React.createClass({
   // TOOD: Put a better type for _picker
   _picker: (undefined: ?$FlowFixMe),
@@ -102,6 +103,7 @@ const DatePickerIOS = React.createClass({
     this.props.onDateChange && this.props.onDateChange(
       new Date(nativeTimeStamp)
     );
+    // $FlowFixMe(>=0.41.0)
     this.props.onChange && this.props.onChange(event);
 
     // We expect the onChange* handlers to be in charge of updating our `date`
diff --git a/Libraries/Components/Keyboard/KeyboardAvoidingView.js b/Libraries/Components/Keyboard/KeyboardAvoidingView.js
@@ -52,6 +52,7 @@ const viewRef = 'VIEW';
  * It is a component to solve the common problem of views that need to move out of the way of the virtual keyboard.
  * It can automatically adjust either its position or bottom padding based on the position of the keyboard.
  */
+// $FlowFixMe(>=0.41.0)
 const KeyboardAvoidingView = React.createClass({
   mixins: [TimerMixin],
 
@@ -153,6 +154,7 @@ const KeyboardAvoidingView = React.createClass({
   },
 
   render(): React.Element<any> {
+    // $FlowFixMe(>=0.41.0)
     const {behavior, children, style, ...props} = this.props;
 
     switch (behavior) {
diff --git a/Libraries/Components/MapView/MapView.js b/Libraries/Components/MapView/MapView.js
@@ -84,6 +84,7 @@ export type AnnotationDragState = $Enum<{
  *
  */
 
+// $FlowFixMe(>=0.41.0)
 const MapView = React.createClass({
 
   mixins: [NativeMethodsMixin],
@@ -519,6 +520,7 @@ const MapView = React.createClass({
 
     // followUserLocation defaults to true if showUserLocation is set
     if (followUserLocation === undefined) {
+      // $FlowFixMe(>=0.41.0)
       followUserLocation = this.props.showUserLocation;
     }
 
diff --git a/Libraries/Components/Navigation/NavigatorIOS.ios.js b/Libraries/Components/Navigation/NavigatorIOS.ios.js
@@ -884,6 +884,7 @@ var NavigatorIOS = React.createClass({
         <NavigatorTransitionerIOS
           ref={TRANSITIONER_REF}
           style={styles.transitioner}
+          // $FlowFixMe(>=0.41.0)
           vertical={this.props.vertical}
           requestedTopOfStack={this.state.requestedTopOfStack}
           onNavigationComplete={this._handleNavigationComplete}
@@ -914,6 +915,7 @@ var NavigatorIOS = React.createClass({
 
   render: function() {
     return (
+      // $FlowFixMe(>=0.41.0)
       <View style={this.props.style}>
         {this._renderNavigationStackItems()}
       </View>
diff --git a/Libraries/Components/Picker/Picker.js b/Libraries/Components/Picker/Picker.js
@@ -69,6 +69,7 @@ class Picker extends React.Component {
    mode: MODE_DIALOG,
  };
 
+ // $FlowFixMe(>=0.41.0)
  static propTypes = {
    ...View.propTypes,
    style: pickerStyleType,
diff --git a/Libraries/Components/ProgressViewIOS/ProgressViewIOS.ios.js b/Libraries/Components/ProgressViewIOS/ProgressViewIOS.ios.js
@@ -24,6 +24,7 @@ var PropTypes = React.PropTypes;
 /**
  * Use `ProgressViewIOS` to render a UIProgressView on iOS.
  */
+// $FlowFixMe(>=0.41.0)
 var ProgressViewIOS = React.createClass({
   mixins: [NativeMethodsMixin],
 
diff --git a/Libraries/Components/RefreshControl/RefreshControl.js b/Libraries/Components/RefreshControl/RefreshControl.js
@@ -70,6 +70,7 @@ if (Platform.OS === 'android') {
  * __Note:__ `refreshing` is a controlled prop, this is why it needs to be set to true
  * in the `onRefresh` function otherwise the refresh indicator will stop immediately.
  */
+// $FlowFixMe(>=0.41.0)
 const RefreshControl = React.createClass({
   statics: {
     SIZE: RefreshLayoutConsts.SIZE,
diff --git a/Libraries/Components/ScrollView/ScrollView.js b/Libraries/Components/ScrollView/ScrollView.js
@@ -67,6 +67,7 @@ const requireNativeComponent = require('requireNativeComponent');
  * multiple columns, infinite scroll loading, or any number of other features it
  * supports out of the box.
  */
+// $FlowFixMe(>=0.41.0)
 const ScrollView = React.createClass({
   propTypes: {
     ...View.propTypes,
diff --git a/Libraries/Components/SegmentedControlIOS/SegmentedControlIOS.ios.js b/Libraries/Components/SegmentedControlIOS/SegmentedControlIOS.ios.js
@@ -49,6 +49,7 @@ type Event = Object;
  * />
  * ````
  */
+// $FlowFixMe(>=0.41.0)
 var SegmentedControlIOS = React.createClass({
   mixins: [NativeMethodsMixin],
 
diff --git a/Libraries/Components/Slider/Slider.js b/Libraries/Components/Slider/Slider.js
@@ -29,6 +29,7 @@ type Event = Object;
 /**
  * A component used to select a single value from a range of values.
  */
+// $FlowFixMe(>=0.41.0)
 var Slider = React.createClass({
   mixins: [NativeMethodsMixin],
 
diff --git a/Libraries/Components/Switch/Switch.js b/Libraries/Components/Switch/Switch.js
@@ -38,6 +38,7 @@ type DefaultProps = {
  * @keyword checkbox
  * @keyword toggle
  */
+// $FlowFixMe(>=0.41.0)
 var Switch = React.createClass({
   propTypes: {
     ...View.propTypes,
diff --git a/Libraries/Components/TabBarIOS/TabBarIOS.ios.js b/Libraries/Components/TabBarIOS/TabBarIOS.ios.js
@@ -32,6 +32,7 @@ class TabBarIOS extends React.Component {
 
   static Item = TabBarItemIOS;
 
+  // $FlowFixMe(>=0.41.0)
   static propTypes = {
     ...View.propTypes,
     style: View.propTypes.style,
diff --git a/Libraries/Components/TextInput/TextInput.js b/Libraries/Components/TextInput/TextInput.js
@@ -168,6 +168,7 @@ const DataDetectorTypes = [
  * or control this param programmatically with native code.
  *
  */
+// $FlowFixMe(>=0.41.0)
 const TextInput = React.createClass({
   statics: {
     /* TODO(brentvatne) docs are needed for this */
diff --git a/Libraries/Components/Touchable/TouchableBounce.js b/Libraries/Components/Touchable/TouchableBounce.js
@@ -33,6 +33,7 @@ var PRESS_RETENTION_OFFSET = {top: 20, left: 20, right: 20, bottom: 30};
  * `TouchableMixin` expects us to implement some abstract methods to handle
  * interesting interactions such as `handleTouchablePress`.
  */
+// $FlowFixMe(>=0.41.0)
 var TouchableBounce = React.createClass({
   mixins: [Touchable.Mixin, NativeMethodsMixin],
 
@@ -148,7 +149,9 @@ var TouchableBounce = React.createClass({
         onResponderMove={this.touchableHandleResponderMove}
         onResponderRelease={this.touchableHandleResponderRelease}
         onResponderTerminate={this.touchableHandleResponderTerminate}>
-        {this.props.children}
+        {
+          // $FlowFixMe(>=0.41.0)
+          this.props.children}
         {Touchable.renderDebugView({color: 'orange', hitSlop: this.props.hitSlop})}
       </Animated.View>
     );
diff --git a/Libraries/Components/Touchable/TouchableWithoutFeedback.js b/Libraries/Components/Touchable/TouchableWithoutFeedback.js
@@ -31,6 +31,7 @@ const PRESS_RETENTION_OFFSET = {top: 20, left: 20, right: 20, bottom: 30};
  * TouchableWithoutFeedback supports only one child.
  * If you wish to have several child components, wrap them in a View.
  */
+// $FlowFixMe(>=0.41.0)
 const TouchableWithoutFeedback = React.createClass({
   mixins: [TimerMixin, Touchable.Mixin],
 
@@ -147,6 +148,7 @@ const TouchableWithoutFeedback = React.createClass({
 
   render: function(): React.Element<any> {
     // Note(avik): remove dynamic typecast once Flow has been upgraded
+    // $FlowFixMe(>=0.41.0)
     const child = React.Children.only(this.props.children);
     let children = child.props.children;
     warning(
@@ -163,9 +165,11 @@ const TouchableWithoutFeedback = React.createClass({
       child.props.style;
     return (React: any).cloneElement(child, {
       accessible: this.props.accessible !== false,
+      // $FlowFixMe(>=0.41.0)
       accessibilityLabel: this.props.accessibilityLabel,
       accessibilityComponentType: this.props.accessibilityComponentType,
       accessibilityTraits: this.props.accessibilityTraits,
+      // $FlowFixMe(>=0.41.0)
       testID: this.props.testID,
       onLayout: this.props.onLayout,
       hitSlop: this.props.hitSlop,
diff --git a/Libraries/Components/View/View.js b/Libraries/Components/View/View.js
@@ -98,6 +98,7 @@ const statics = {
  *   - `timestamp` - A time identifier for the touch, useful for velocity calculation.
  *   - `touches` - Array of all current touches on the screen.
  */
+// $FlowFixMe(>=0.41.0)
 const View = React.createClass({
   // TODO: We should probably expose the mixins, viewConfig, and statics publicly. For example,
   // one of the props is of type AccessibilityComponentType. That is defined as a const[] above,
diff --git a/Libraries/Image/Image.ios.js b/Libraries/Image/Image.ios.js
@@ -126,6 +126,7 @@ const ImageViewManager = NativeModules.ImageViewManager;
  * ```
  *
  */
+// $FlowFixMe(>=0.41.0)
 const Image = React.createClass({
   propTypes: {
     /**
diff --git a/Libraries/RCTTest/SnapshotViewIOS.ios.js b/Libraries/RCTTest/SnapshotViewIOS.ios.js
@@ -25,6 +25,7 @@ class SnapshotViewIOS extends React.Component {
     testIdentifier?: string,
   };
 
+  // $FlowFixMe(>=0.41.0)
   static propTypes = {
     ...View.propTypes,
     // A callback when the Snapshot view is ready to be compared
diff --git a/Libraries/Text/Text.js b/Libraries/Text/Text.js
@@ -95,6 +95,7 @@ const viewConfig = {
  * ```
  */
 
+// $FlowFixMe(>=0.41.0)
 const Text = React.createClass({
   propTypes: {
     /**
@@ -248,6 +249,7 @@ const Text = React.createClass({
         this._handlers = {
           onStartShouldSetResponder: (): bool => {
             const shouldSetFromProps = this.props.onStartShouldSetResponder &&
+                // $FlowFixMe(>=0.41.0)
                 this.props.onStartShouldSetResponder();
             const setResponder = shouldSetFromProps || this._hasPressHandler();
             if (setResponder && !this.touchableHandleActivePressIn) {
@@ -288,33 +290,44 @@ const Text = React.createClass({
                 return this.props.pressRetentionOffset || PRESS_RECT_OFFSET;
               };
             }
+            // $FlowFixMe(>=0.41.0)
             return setResponder;
           },
           onResponderGrant: function(e: SyntheticEvent, dispatchID: string) {
+            // $FlowFixMe(>=0.41.0)
             this.touchableHandleResponderGrant(e, dispatchID);
             this.props.onResponderGrant &&
+              // $FlowFixMe(>=0.41.0)
               this.props.onResponderGrant.apply(this, arguments);
           }.bind(this),
           onResponderMove: function(e: SyntheticEvent) {
+            // $FlowFixMe(>=0.41.0)
             this.touchableHandleResponderMove(e);
             this.props.onResponderMove &&
+              // $FlowFixMe(>=0.41.0)
               this.props.onResponderMove.apply(this, arguments);
           }.bind(this),
           onResponderRelease: function(e: SyntheticEvent) {
+            // $FlowFixMe(>=0.41.0)
             this.touchableHandleResponderRelease(e);
             this.props.onResponderRelease &&
+              // $FlowFixMe(>=0.41.0)
               this.props.onResponderRelease.apply(this, arguments);
           }.bind(this),
           onResponderTerminate: function(e: SyntheticEvent) {
+            // $FlowFixMe(>=0.41.0)
             this.touchableHandleResponderTerminate(e);
             this.props.onResponderTerminate &&
+              // $FlowFixMe(>=0.41.0)
               this.props.onResponderTerminate.apply(this, arguments);
           }.bind(this),
           onResponderTerminationRequest: function(): bool {
             // Allow touchable or props.onResponderTerminationRequest to deny
             // the request
+            // $FlowFixMe(>=0.41.0)
             var allowTermination = this.touchableHandleResponderTerminationRequest();
             if (allowTermination && this.props.onResponderTerminationRequest) {
+              // $FlowFixMe(>=0.41.0)
               allowTermination = this.props.onResponderTerminationRequest.apply(this, arguments);
             }
             return allowTermination;
diff --git a/local-cli/templates/HelloWorld/_flowconfig b/local-cli/templates/HelloWorld/_flowconfig
@@ -36,12 +36,12 @@ suppress_type=$FlowIssue
 suppress_type=$FlowFixMe
 suppress_type=$FixMe
 
-suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(4[0-0]\\|[1-3][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)
-suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(4[0-0]\\|[1-3][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)?:? #[0-9]+
+suppress_comment=\\(.\\|\n\\)*\\$FlowFixMe\\($\\|[^(]\\|(\\(>=0\\.\\(4[0-1]\\|[1-3][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)
+suppress_comment=\\(.\\|\n\\)*\\$FlowIssue\\((\\(>=0\\.\\(4[0-1]\\|[1-3][0-9]\\|[0-9]\\).[0-9]\\)? *\\(site=[a-z,_]*react_native[a-z,_]*\\)?)\\)?:? #[0-9]+
 suppress_comment=\\(.\\|\n\\)*\\$FlowFixedInNextDeploy
 suppress_comment=\\(.\\|\n\\)*\\$FlowExpectedError
 
 unsafe.enable_getters_and_setters=true
 
 [version]
-^0.40.0
+^0.41.0
diff --git a/package.json b/package.json
@@ -217,7 +217,7 @@
     "eslint-plugin-babel": "^3.3.0",
     "eslint-plugin-flowtype": "^2.20.0",
     "eslint-plugin-react": "^6.4.1",
-    "flow-bin": "^0.40.0",
+    "flow-bin": "^0.41.0",
     "jest": "19.0.2",
     "jest-repl": "19.0.2",
     "jest-runtime": "19.0.2",

Original file line number	Diff line number	Diff line change
`@@ -84,6 +84,7 @@ export type AnnotationDragState = $Enum<{`
`84`	`84`	`*`
`85`	`85`	`*/`
`86`	`86`
	`87`	`+// $FlowFixMe(>=0.41.0)`
`87`	`88`	`const MapView = React.createClass({`
`88`	`89`
`89`	`90`	`mixins: [NativeMethodsMixin],`
`@@ -519,6 +520,7 @@ const MapView = React.createClass({`
`519`	`520`
`520`	`521`	`// followUserLocation defaults to true if showUserLocation is set`
`521`	`522`	`if (followUserLocation === undefined) {`
	`523`	`+ // $FlowFixMe(>=0.41.0)`
`522`	`524`	`followUserLocation = this.props.showUserLocation;`
`523`	`525`	`}`
`524`	`526`