android support library 28.0.0 (#23109)

dulmandakh · facebook-github-bot · commit 5bbed4385495 · 2019-01-23T02:22:00.000-08:00
Summary: Bump Android Support Library to 28.0.0. Therefore fix Android CI Changelog: ---------- [Android] [Changed] - Bump Android Support Library to 28.0.0. Pull Request resolved: #23109 Differential Revision: D13779835 Pulled By: mdvacca fbshipit-source-id: 7645ffe2c04ca81424b2f9cfa43dc4ec30c50e25
diff --git a/ReactAndroid/src/main/java/com/facebook/react/bridge/BUCK b/ReactAndroid/src/main/java/com/facebook/react/bridge/BUCK
@@ -22,14 +22,12 @@ rn_android_library(
     proguard_config = "reactnative.pro",
     provided_deps = [
         react_native_dep("third-party/android/support/v4:lib-support-v4"),
-        react_native_dep("third-party/android/support-annotations:android-support-annotations"),
     ],
     required_for_source_only_abi = True,
     visibility = [
         "PUBLIC",
     ],
     deps = [
-        react_native_dep("third-party/android/support-annotations:android-support-annotations"),
         react_native_dep("java/com/facebook/debug/debugoverlay/model:model"),
         react_native_dep("java/com/facebook/systrace:systrace"),
         react_native_dep("libraries/fbcore/src/main/java/com/facebook/common/logging:logging"),
diff --git a/ReactAndroid/src/main/java/com/facebook/react/devsupport/BUCK b/ReactAndroid/src/main/java/com/facebook/react/devsupport/BUCK
@@ -12,7 +12,6 @@ rn_android_library(
     ],
     deps = [
         react_native_dep("libraries/fbcore/src/main/java/com/facebook/common/logging:logging"),
-        react_native_dep("third-party/android/support-annotations:android-support-annotations"),
         react_native_dep("third-party/java/infer-annotations:infer-annotations"),
         react_native_dep("third-party/java/jsr-305:jsr-305"),
         react_native_dep("third-party/java/okhttp:okhttp3"),
diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/blob/BUCK b/ReactAndroid/src/main/java/com/facebook/react/modules/blob/BUCK
@@ -4,7 +4,6 @@ rn_android_library(
     name = "blob",
     srcs = glob(["**/*.java"]),
     provided_deps = [
-        react_native_dep("third-party/android/support-annotations:android-support-annotations"),
         react_native_dep("third-party/android/support/v4:lib-support-v4"),
     ],
     visibility = [
diff --git a/ReactAndroid/src/main/java/com/facebook/react/modules/fresco/BUCK b/ReactAndroid/src/main/java/com/facebook/react/modules/fresco/BUCK
@@ -4,7 +4,6 @@ rn_android_library(
     name = "fresco",
     srcs = glob(["**/*.java"]),
     provided_deps = [
-        react_native_dep("third-party/android/support-annotations:android-support-annotations"),
         react_native_dep("third-party/android/support/v4:lib-support-v4"),
     ],
     visibility = [
diff --git a/ReactAndroid/src/main/java/com/facebook/react/uimanager/BUCK b/ReactAndroid/src/main/java/com/facebook/react/uimanager/BUCK
@@ -13,7 +13,6 @@ rn_android_library(
     ),
     provided_deps = [
         react_native_dep("third-party/android/support/v4:lib-support-v4"),
-        react_native_dep("third-party/android/support-annotations:android-support-annotations"),
     ],
     required_for_source_only_abi = True,
     visibility = [
diff --git a/ReactAndroid/src/main/java/com/facebook/react/uimanager/common/BUCK b/ReactAndroid/src/main/java/com/facebook/react/uimanager/common/BUCK
@@ -5,7 +5,6 @@ rn_android_library(
     srcs = glob(["*.java"]),
     provided_deps = [
         react_native_dep("third-party/android/support/v4:lib-support-v4"),
-        react_native_dep("third-party/android/support-annotations:android-support-annotations"),
     ],
     visibility = [
         "PUBLIC",
diff --git a/ReactAndroid/src/main/java/com/facebook/react/views/image/BUCK b/ReactAndroid/src/main/java/com/facebook/react/views/image/BUCK
@@ -8,7 +8,6 @@ rn_android_library(
     name = "imageevents",
     srcs = IMAGE_EVENT_FILES,
     provided_deps = [
-        react_native_dep("third-party/android/support-annotations:android-support-annotations"),
         react_native_dep("third-party/android/support/v4:lib-support-v4"),
     ],
     required_for_source_only_abi = True,
@@ -27,7 +26,6 @@ rn_android_library(
         exclude = IMAGE_EVENT_FILES,
     ),
     provided_deps = [
-        react_native_dep("third-party/android/support-annotations:android-support-annotations"),
         react_native_dep("third-party/android/support/v4:lib-support-v4"),
     ],
     visibility = [
diff --git a/ReactAndroid/src/main/third-party/android/support-annotations/BUCK b/ReactAndroid/src/main/third-party/android/support-annotations/BUCK
@@ -9,6 +9,6 @@ rn_prebuilt_jar(
 
 fb_native.remote_file(
     name = "support-annotations-binary.jar",
-    sha1 = "39ded76b5e1ce1c5b2688e1d25cdc20ecee32007",
+    sha1 = "ed73f5337a002d1fd24339d5fb08c2c9d9ca60d8",
     url = "mvn:com.android.support:support-annotations:jar:28.0.0",
 )
diff --git a/ReactAndroid/src/main/third-party/android/support/v4/BUCK b/ReactAndroid/src/main/third-party/android/support/v4/BUCK
diff --git a/ReactAndroid/src/main/third-party/android/support/v7/appcompat-orig/BUCK b/ReactAndroid/src/main/third-party/android/support/v7/appcompat-orig/BUCK
diff --git a/template/android/build.gradle b/template/android/build.gradle

Original file line number	Diff line number	Diff line change
`@@ -9,6 +9,6 @@ rn_prebuilt_jar(`
`9`	`9`
`10`	`10`	`fb_native.remote_file(`
`11`	`11`	`name = "support-annotations-binary.jar",`
`12`		`- sha1 = "39ded76b5e1ce1c5b2688e1d25cdc20ecee32007",`
	`12`	`+ sha1 = "ed73f5337a002d1fd24339d5fb08c2c9d9ca60d8",`
`13`	`13`	`url = "mvn:com.android.support:support-annotations:jar:28.0.0",`
`14`	`14`	`)`