attempt to fix maintain visible content position prop with view culling (#53472)

Summary:
Pull Request resolved: #53472

changelog: [internal]

I am looking into stalls when View Culling is turned on together with immediate state updates. This is one of the places where stalls are concentrated and this seems like a possible culprit:
When view is moved outside of the viewport, it is immediately reused. Therefore, we must check view's identity to make sure it is the same view before and after transaction.

Reviewed By: lenaic

Differential Revision: D81044328

fbshipit-source-id: 796b71219e5fc94c1f98319b73f4655b9c13000f

Author: sammy-SC

packages/react-native/React/Fabric/Mounting/ComponentViews/ScrollView/RCTScrollViewComponentView.mm

@@ -111,6 +111,7 @@ @implementation RCTScrollViewComponentView {
 
   CGRect _prevFirstVisibleFrame;
   __weak UIView *_firstVisibleView;
+  NSInteger _firstVisibleViewTag;
 
   CGFloat _endDraggingSensitivityMultiplier;
 
@@ -691,6 +692,7 @@ - (void)prepareForRecycle
   _contentView = nil;
   _prevFirstVisibleFrame = CGRectZero;
   _firstVisibleView = nil;
+  _firstVisibleViewTag = 0;
   _virtualViewContainerState = nil;
 }
 
@@ -1041,7 +1043,7 @@ - (void)removeScrollListener:(NSObject<UIScrollViewDelegate> *)scrollListener
 - (void)_prepareForMaintainVisibleScrollPosition
 {
   const auto &props = static_cast<const ScrollViewProps &>(*_props);
-  if (!props.maintainVisibleContentPosition) {
+  if (!props.maintainVisibleContentPosition || _avoidAdjustmentForMaintainVisibleContentPosition) {
     return;
   }
 
@@ -1059,6 +1061,7 @@ - (void)_prepareForMaintainVisibleScrollPosition
     if (hasNewView || ii == _contentView.subviews.count - 1) {
       _prevFirstVisibleFrame = subview.frame;
       _firstVisibleView = subview;
+      _firstVisibleViewTag = subview.tag;
       break;
     }
   }
@@ -1071,6 +1074,13 @@ - (void)_adjustForMaintainVisibleContentPosition
     return;
   }
 
+  if (ReactNativeFeatureFlags::enableViewCulling()) {
+    // Abort if the first visible view has changed (different tag)
+    if (_firstVisibleView && _firstVisibleView.tag != _firstVisibleViewTag) {
+      return;
+    }
+  }
+
   std::optional<int> autoscrollThreshold = props.maintainVisibleContentPosition.value().autoscrollToTopThreshold;
   BOOL horizontal = _scrollView.contentSize.width > self.frame.size.width;
   // TODO: detect and handle/ignore re-ordering