Skip to content

Commit 7eb3536

Browse files
huntiefacebook-github-bot
authored andcommitted
Add openDebugger overload with target panel name (#53485)
Summary: Pull Request resolved: #53485 Adds new `openDebugger(panel)` overload on `DevSupportManager` (following D79329081). Changelog: [Android][Added] - `DevSupportManager::openDebugger` now supports an optional `panel` param Reviewed By: hoxyq Differential Revision: D81138169 fbshipit-source-id: 282da9fbc055fa4ce94cd2d0790ca4d29c55bfa8
1 parent 1618a8e commit 7eb3536

File tree

4 files changed

+18
-0
lines changed

4 files changed

+18
-0
lines changed

packages/react-native/ReactAndroid/api/ReactAndroid.api

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1963,6 +1963,7 @@ public abstract class com/facebook/react/devsupport/DevSupportManagerBase : com/
19631963
public fun onNewReactContextCreated (Lcom/facebook/react/bridge/ReactContext;)V
19641964
public fun onReactInstanceDestroyed (Lcom/facebook/react/bridge/ReactContext;)V
19651965
public fun openDebugger ()V
1966+
public fun openDebugger (Lcom/facebook/react/devsupport/interfaces/DebuggerFrontendPanelName;)V
19661967
public fun processErrorCustomizers (Landroid/util/Pair;)Landroid/util/Pair;
19671968
public fun registerErrorCustomizer (Lcom/facebook/react/devsupport/interfaces/ErrorCustomizer;)V
19681969
public fun reloadJSFromServer (Ljava/lang/String;Lcom/facebook/react/devsupport/interfaces/BundleLoadCallback;)V
@@ -2052,6 +2053,7 @@ public class com/facebook/react/devsupport/ReleaseDevSupportManager : com/facebo
20522053
public fun onNewReactContextCreated (Lcom/facebook/react/bridge/ReactContext;)V
20532054
public fun onReactInstanceDestroyed (Lcom/facebook/react/bridge/ReactContext;)V
20542055
public fun openDebugger ()V
2056+
public fun openDebugger (Lcom/facebook/react/devsupport/interfaces/DebuggerFrontendPanelName;)V
20552057
public fun processErrorCustomizers (Landroid/util/Pair;)Landroid/util/Pair;
20562058
public fun registerErrorCustomizer (Lcom/facebook/react/devsupport/interfaces/ErrorCustomizer;)V
20572059
public fun reloadJSFromServer (Ljava/lang/String;Lcom/facebook/react/devsupport/interfaces/BundleLoadCallback;)V
@@ -2161,6 +2163,7 @@ public abstract interface class com/facebook/react/devsupport/interfaces/DevSupp
21612163
public abstract fun onNewReactContextCreated (Lcom/facebook/react/bridge/ReactContext;)V
21622164
public abstract fun onReactInstanceDestroyed (Lcom/facebook/react/bridge/ReactContext;)V
21632165
public abstract fun openDebugger ()V
2166+
public abstract fun openDebugger (Lcom/facebook/react/devsupport/interfaces/DebuggerFrontendPanelName;)V
21642167
public abstract fun processErrorCustomizers (Landroid/util/Pair;)Landroid/util/Pair;
21652168
public abstract fun registerErrorCustomizer (Lcom/facebook/react/devsupport/interfaces/ErrorCustomizer;)V
21662169
public abstract fun reloadJSFromServer (Ljava/lang/String;Lcom/facebook/react/devsupport/interfaces/BundleLoadCallback;)V

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/DevSupportManagerBase.kt

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -52,6 +52,7 @@ import com.facebook.react.devsupport.InspectorFlags.getFuseboxEnabled
5252
import com.facebook.react.devsupport.StackTraceHelper.convertJavaStackTrace
5353
import com.facebook.react.devsupport.StackTraceHelper.convertJsStackTrace
5454
import com.facebook.react.devsupport.interfaces.BundleLoadCallback
55+
import com.facebook.react.devsupport.interfaces.DebuggerFrontendPanelName
5556
import com.facebook.react.devsupport.interfaces.DevBundleDownloadListener
5657
import com.facebook.react.devsupport.interfaces.DevLoadingViewManager
5758
import com.facebook.react.devsupport.interfaces.DevOptionHandler
@@ -927,6 +928,14 @@ public abstract class DevSupportManagerBase(
927928
)
928929
}
929930

931+
override fun openDebugger(panel: DebuggerFrontendPanelName) {
932+
devServerHelper.openDebugger(
933+
currentReactContext,
934+
applicationContext.getString(R.string.catalyst_open_debugger_error),
935+
panel,
936+
)
937+
}
938+
930939
override fun showPausedInDebuggerOverlay(
931940
message: String,
932941
listener: PausedInDebuggerOverlayCommandListener,

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/ReleaseDevSupportManager.kt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import com.facebook.react.bridge.ReactContext
1616
import com.facebook.react.bridge.ReadableArray
1717
import com.facebook.react.common.SurfaceDelegate
1818
import com.facebook.react.devsupport.interfaces.BundleLoadCallback
19+
import com.facebook.react.devsupport.interfaces.DebuggerFrontendPanelName
1920
import com.facebook.react.devsupport.interfaces.DevOptionHandler
2021
import com.facebook.react.devsupport.interfaces.DevSupportManager
2122
import com.facebook.react.devsupport.interfaces.DevSupportManager.PackagerLocationCustomizer
@@ -144,6 +145,8 @@ public open class ReleaseDevSupportManager : DevSupportManager {
144145

145146
public override fun openDebugger(): Unit = Unit
146147

148+
public override fun openDebugger(panel: DebuggerFrontendPanelName): Unit = Unit
149+
147150
public override fun showPausedInDebuggerOverlay(
148151
message: String,
149152
listener: PausedInDebuggerOverlayCommandListener,

packages/react-native/ReactAndroid/src/main/java/com/facebook/react/devsupport/interfaces/DevSupportManager.kt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,9 @@ public interface DevSupportManager : JSExceptionHandler {
9797
/** Attempt to open the JS debugger on the host machine. */
9898
public fun openDebugger()
9999

100+
/** Attempt to open the JS debugger on the host machine, providing a destination panel name. */
101+
public fun openDebugger(panel: DebuggerFrontendPanelName)
102+
100103
/** Shows the "paused in debugger" overlay with the given message. */
101104
public fun showPausedInDebuggerOverlay(
102105
message: String,

0 commit comments

Comments
 (0)