Skip to content

Commit abc8fe1

Browse files
cipolleschifacebook-github-bot
authored andcommitted
Fix nightly download of Hermes and react-native-dependencies (#52033)
Summary: Pull Request resolved: #52033 This change fixes the download of the artefacts for the nightlies of Hermes and React Native Dependencies after we changed the publishing logic for Maven ## Changelog: [Internal] - Reviewed By: cortinico Differential Revision: D76723289 fbshipit-source-id: 6b0ea6a6c35125e6fb03cecc6be893bd02abdad8
1 parent a6ea626 commit abc8fe1

File tree

2 files changed

+22
-4
lines changed

2 files changed

+22
-4
lines changed

packages/react-native/scripts/cocoapods/rndependencies.rb

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -142,8 +142,17 @@ def self.release_tarball_url(version, build_type)
142142
end
143143

144144
def self.nightly_tarball_url(version)
145-
params = "r=snapshots\&g=com.facebook.react\&a=react-native-artifacts\&c=reactnative-dependencies-debug\&e=tar.gz\&v=#{version}-SNAPSHOT"
146-
return resolve_url_redirects("http://oss.sonatype.org/service/local/artifact/maven/redirect\?#{params}")
145+
artefact_coordinate = "react-native-artifacts"
146+
artefact_name = "reactnative-dependencies-debug.tar.gz"
147+
xml_url = "https://central.sonatype.com/repository/maven-snapshots/com/facebook/react/#{artefact_coordinate}/#{version}-SNAPSHOT/maven-metadata.xml"
148+
149+
xml = REXML::Document.new(Net::HTTP.get(URI(xml_url)))
150+
timestamp = xml.elements['metadata/versioning/snapshot/timestamp'].text
151+
build_number = xml.elements['metadata/versioning/snapshot/buildNumber'].text
152+
full_version = "#{version}-#{timestamp}-#{build_number}"
153+
154+
final_url = "https://central.sonatype.com/repository/maven-snapshots/com/facebook/react/#{artefact_coordinate}/#{version}-SNAPSHOT/#{artefact_coordinate}-#{full_version}-#{artefact_name}"
155+
return final_url
147156
end
148157

149158
def self.download_stable_rndeps(react_native_path, version, configuration)

packages/react-native/sdks/hermes-engine/hermes-utils.rb

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -230,8 +230,17 @@ def download_hermes_tarball(react_native_path, tarball_url, version, configurati
230230
end
231231

232232
def nightly_tarball_url(version)
233-
params = "r=snapshots\&g=com.facebook.react\&a=react-native-artifacts\&c=hermes-ios-debug\&e=tar.gz\&v=#{version}-SNAPSHOT"
234-
return resolve_url_redirects("http://oss.sonatype.org/service/local/artifact/maven/redirect\?#{params}")
233+
artefact_coordinate = "react-native-artifacts"
234+
artefact_name = "hermes-ios-debug.tar.gz"
235+
xml_url = "https://central.sonatype.com/repository/maven-snapshots/com/facebook/react/#{artefact_coordinate}/#{version}-SNAPSHOT/maven-metadata.xml"
236+
237+
xml = REXML::Document.new(Net::HTTP.get(URI(xml_url)))
238+
timestamp = xml.elements['metadata/versioning/snapshot/timestamp'].text
239+
build_number = xml.elements['metadata/versioning/snapshot/buildNumber'].text
240+
full_version = "#{version}-#{timestamp}-#{build_number}"
241+
242+
final_url = "https://central.sonatype.com/repository/maven-snapshots/com/facebook/react/#{artefact_coordinate}/#{version}-SNAPSHOT/#{artefact_coordinate}-#{full_version}-#{artefact_name}"
243+
return final_url
235244
end
236245

237246
def resolve_url_redirects(url)

0 commit comments

Comments
 (0)