Skip to content

Commit c267a06

Browse files
Sunbreakfacebook-github-bot
authored andcommitted
Fix type in BlobCollector.h/cpp (#41404)
Summary: When working on JSI module, `BlobCollector`'s `nativeInstall` is a good example. But the first type should be `jni::alias_ref<jclass>` according to https://github.com/facebookincubator/fbjni/blob/main/docs/quickref.md#basic-method-usage-java-to-c-and-c-to-java Fix type in BlobCollector.h/cpp ## Changelog: [ANDROID] [FIXED] - Fix type in BlobCollector.h/cpp Pull Request resolved: #41404 Test Plan: None Reviewed By: cipolleschi Differential Revision: D51198049 Pulled By: javache fbshipit-source-id: 86f471cbe3cd683a7be605ce127b3b3c3769c037
1 parent 88e3913 commit c267a06

File tree

2 files changed

+3
-5
lines changed

2 files changed

+3
-5
lines changed

packages/react-native/ReactAndroid/src/main/jni/react/reactnativeblob/BlobCollector.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ BlobCollector::~BlobCollector() {
3333
}
3434

3535
void BlobCollector::nativeInstall(
36-
jni::alias_ref<jhybridobject> jThis,
36+
jni::alias_ref<jclass>,
3737
jni::alias_ref<jobject> blobModule,
3838
jlong jsContextNativePointer) {
3939
auto& runtime = *((jsi::Runtime*)jsContextNativePointer);

packages/react-native/ReactAndroid/src/main/jni/react/reactnativeblob/BlobCollector.h

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -15,16 +15,14 @@ namespace facebook::react {
1515
class BlobCollector : public jni::HybridClass<BlobCollector>,
1616
public jsi::HostObject {
1717
public:
18-
BlobCollector(
19-
jni::global_ref<jobject> blobManager,
20-
const std::string& blobId);
18+
BlobCollector(jni::global_ref<jobject> blobModule, const std::string& blobId);
2119
~BlobCollector();
2220

2321
static constexpr auto kJavaDescriptor =
2422
"Lcom/facebook/react/modules/blob/BlobCollector;";
2523

2624
static void nativeInstall(
27-
jni::alias_ref<jhybridobject> jThis,
25+
jni::alias_ref<jclass>,
2826
jni::alias_ref<jobject> blobModule,
2927
jlong jsContextNativePointer);
3028

0 commit comments

Comments
 (0)