Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing Modal and showing Alert simultaneously locks up app #10727

Closed
jasonmerino opened this issue Nov 4, 2016 · 2 comments
Closed

Closing Modal and showing Alert simultaneously locks up app #10727

jasonmerino opened this issue Nov 4, 2016 · 2 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@jasonmerino
Copy link

Description

What I did.

  • Had a Modal component visible and attempted to close it and show an Alert at the same time

What I expected to happen

  • The Modal component to dismiss as the Alert is being shown

What actually happened

  • The app locks up, refreshing the JS bundle doesn't change anything even though it shows the loading bar at the top of the screen.
  • No visible error messages in Xcode or in Chrome debugger.

Reproduction

Sample project with reproduction case is here: https://github.com/jasonmerino/ModalAlertCombo

Additional Information

  • React Native version: 0.36.0
  • Platform: iOS only (simulator and iPhone) (the same code works on Android)
  • Operating System: MacOS

I've done a little debugging on my end and it looks like the issue is with the presenting controller that the Alert is being attached to. When you set a timeout to Alert after the Modal has been fully removed the RCTPresentedViewControllermethod returns the UIViewController rather than the RCTModalHostView.

Not sure why it's functioning as it does, it doesn't crash or anything. It just locks up and the app is unusable.

@nihgwu
Copy link
Contributor

nihgwu commented Nov 4, 2016

dup of #10471

@jasonmerino
Copy link
Author

Closing in favor of #10471

@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

3 participants