-
Notifications
You must be signed in to change notification settings - Fork 24.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
When rotating an app to landscape the statusbar is hidden #10751
Comments
I also noticed this! @lacker - any idea who to assign to? |
does this repro in the UIExplorer or did something change with our initial config settings? |
@mmmulani yes. It's something wrong in core. When the following is done it happens.
|
oh in that case, do you mind running a bisect? I'm a bit swamped with other work and won't get to look at it for a couple days |
I would like to work on this bug. Any idea on how I should approach it? |
@mrpp01 just find out when this broke. do a git bisect and find out which commit broke it. that should make it easy to fix, or at least find out why. |
@pvinis I have tried to identify a good version of react native where the error does not exist. But as far as version 0.14.2, the error still exists. I tried to test on older versions, but had not been able to make it run. I doubt that bisect would be helpful as the bug might exist since the beginning. Is there any other approaches that you think I should try? |
hm.. then i guess it was not broken. just never worked.. then if you still want to try to fix it, i would suggest to take a look at the statusbar api and the rotation detection for interface and for device api from apple. and maybe you can locate some thing with those. |
Is it possible that this happens due to the fact that, since iOS8 UIViewController’s implementation of prefersStatusBarHidden returns YES when its trait collection’s horizontal size class is compact?
https://developer.apple.com/reference/uikit/uiviewcontroller/1621440-prefersstatusbarhidden |
I am using |
@ferrannp not sure if this will be resolved on the react-native end, but here is a solution that you can use In your [application setStatusBarHidden:YES withAnimation:UIStatusBarAnimationNone];
[application setStatusBarHidden:NO withAnimation:UIStatusBarAnimationNone]; and make sure that This will cause the status bar to be visible in landscape mode. Hope this helps. |
@mzmiric5 nice, this works, thank you! Although, I didn't know default behavior of iOS native apps was to hide it on landscape. I guess this could be documented somewhere if we do not want to add it to |
Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally! If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:
If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution. |
When rotating an app to landscape the statusbar is hidden. This is happening for me. react-native: 0.45.1 |
Please reopen this bug since it is still not solved. react-native: 0.46.3 |
There's been several releases since 0.46.3 was cut. If you're still seeing this in master, please open a new issue. |
This worked for me
|
I also have this bug on 0.52.1 please reopen the issue @hramos |
Description
An app loaded in portrait shows the statusbar and when rotated to landscape hides the statusbar. Rotating the app back to portrait shows the statusbar again.
An app loaded in landscape shows no statusbar. When rotated to portrait still shows no statusbar.
Reproduction
react-native init ProjectName
Additional Information
The text was updated successfully, but these errors were encountered: