Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

when in smartbar case the Dimensions ‘s height is not correct on Android #13031

Closed
shengbo1992 opened this issue Mar 20, 2017 · 1 comment
Closed
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@shengbo1992
Copy link

when the devices have a smartbar,I handle the smartbar on/off, and js use Dimensions get height is not correct,
i saw the code in ReactRootView.java。it use the OnGlobalLayoutListener'callback to notify the js.
but the emitUpdateDimensionsEvent function use DisplayMetricsHolder.getWindowDisplayMetrics() always get the same vaule.

@hramos
Copy link
Contributor

hramos commented Mar 20, 2017

Hey, thanks for reporting this issue!

It looks like your description is missing some necessary information. Can you please add all the details specified in the template? This is necessary for people to be able to understand and reproduce the issue being reported.

I am going to close this, but feel free to open a new issue with the additional information provided. Thanks!

@hramos hramos closed this as completed Mar 20, 2017
@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

3 participants