Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RN43 can't open dev menu when integrating with existing iOS project #13444

Closed
hitbear518 opened this issue Apr 11, 2017 · 3 comments
Closed

RN43 can't open dev menu when integrating with existing iOS project #13444

hitbear518 opened this issue Apr 11, 2017 · 3 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@hitbear518
Copy link

Description

I have an iOS app integrating react-native, after upgrade to 0.43.3, cmd+D can't open dev menu any more.
I tried a empt project, i didn't work either.

Reproduction Steps and Sample Code

I have an empty repo which can reproduce this bug
https://github.com/hitbear518/IntegrationBug

I haven't test Android yet

Additional Information

  • React Native version: 0.43.3
  • Platform: iOS
  • Development Operating System: Mac OS 10.12.4
  • Dev tools: Xcode 8.3.1, Swift 3.0
@mgerb
Copy link

mgerb commented Apr 13, 2017

Experiencing the same issue here except on an actual device (iOS). The shake gesture is not working to bring up the dev menu. I noticed it after I added React to my podfile on 0.42. I upgraded to 0.43.3, but still no success.

I saw a recommendation somewhere to add the subspec 'DevSupport' to the React pod, but that also did not solve the issue for me.

I then removed React from my podfile completely and then the dev menu opened up just fine. This is a frustration for me because I have other dependencies that require React to be in my podfile.

@hitbear518
Copy link
Author

@mgerb Thank you! add DevSupport to podfile solved my problem.
I'm not sure what do you mean by add React to podfile.

Below is my podfile, hope it will help somewhat

# Uncomment this line to define a global platform for your project
# platform :ios, '9.0'

target 'InteTry' do
  # Comment this line if you're not using Swift and don't want to use dynamic frameworks
  use_frameworks!

  # Pods for InteTry
  pod 'React', :path => '../node_modules/react-native', :subspecs => [
    'Core',
    'RCTText',
    'RCTImage',
    'RCTWebSocket', # needed for debugging
    'RCTNetwork',
    'RCTLinkingIOS', # dependency of react-native-router-flux
    'RCTAnimation', # require by useNativeDriver
    'RCTCameraRoll',
    'RCTActionSheet',
    'RCTGeolocation',
    'DevSupport',
  ]
  pod 'Yoga', :path => '../node_modules/react-native/ReactCommon/yoga'

end

@hitbear518
Copy link
Author

🤔After add DevSupport to podfile, it worked fine on simulator, but I encountered another issueNo bundle URL present on iOS device, I'm not sure what caused this.

@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

3 participants