Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

image don't show with good shape on iOS #13582

Closed
7laria opened this issue Apr 19, 2017 · 8 comments
Closed

image don't show with good shape on iOS #13582

7laria opened this issue Apr 19, 2017 · 8 comments
Assignees
Labels
Platform: iOS iOS applications. Resolution: Locked This issue was locked by the bot.

Comments

@7laria
Copy link

7laria commented Apr 19, 2017

whatsapp image 2017-04-19 at 15 38 47
photo6032927663913543737
avatarContainer: {
borderColor: '#9B9B9B',
borderWidth: 1 / PixelRatio.get(),
justifyContent: 'center',
flexDirection:'column',
alignItems: 'center',
marginTop:20
},
avatar: {

borderRadius: 100,
width: 80,
height: 80,

}

@pfulop
Copy link
Contributor

pfulop commented Apr 20, 2017

Border radius should be half of the width (height) if you want to achieve circle. Web css is more forgiving and will just round it up into circle, but in react native you can overshot and create weird shapes.

@shergin shergin added the Platform: iOS iOS applications. label Apr 29, 2017
@shergin
Copy link
Contributor

shergin commented Apr 29, 2017

So, it works on Android exactly like it works on web, right?

@pfulop
Copy link
Contributor

pfulop commented May 2, 2017

@shergin from what I saw yes.

@shergin
Copy link
Contributor

shergin commented May 2, 2017

Yeah, cool, I believe we should fix it on iOS!

@pfulop
Copy link
Contributor

pfulop commented May 2, 2017

@shergin there has been some conversation on this topic in the past #1572 .

@shergin
Copy link
Contributor

shergin commented May 2, 2017

Seems that the issue was fixed for custom "border rendering engine", but not for CALayer based one.
Is this happening only if we apply the border radius to <Image> (not <View>) component?

@hramos
Copy link
Contributor

hramos commented Jul 25, 2017

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

  • Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
  • If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
  • Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.

@hramos hramos added the Icebox label Jul 25, 2017
@hramos hramos closed this as completed Jul 25, 2017
@shergin shergin self-assigned this Jul 28, 2017
@shergin
Copy link
Contributor

shergin commented Jul 28, 2017

We have to fix it. I will try.

@facebook facebook locked as resolved and limited conversation to collaborators Jul 25, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Platform: iOS iOS applications. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

5 participants