Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Releases page does not link to latest release notes if patches available #15018

Closed
hramos opened this issue Jul 14, 2017 · 1 comment
Closed
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@hramos
Copy link
Contributor

hramos commented Jul 14, 2017

Is this a bug report?

Yes, this is a bug in the website generation script.

Have you read the Bugs section of the Contributing to React Native Guide?

Yes.

Environment

This is a website/docs generation issue, specifically one affecting the versions.html page which is always generated from master. The issue is present in master as of this writing, and is unrelated to my local build environment.

Steps to Reproduce

  1. Visit http://facebook.github.io/react-native/versions.html
  2. Click on the release notes for 0.46, or any version that has been patched (as of this writing, 0.46 is up to v0.46.3).

Expected Behavior

Ideally, the user would be shown the release notes for v0.46.3, which are available at https://github.com/facebook/react-native/releases/tag/v0.46.3

Actual Behavior

The release notes for v0.46.0 are shown: https://github.com/facebook/react-native/releases/tag/v0.46.0

This is due to the way the versions.html page is generated. It's based on the directory names used for each version of the website, which are in the form 0.XX (e.g. 0.45, 0.46).

As we release patches, the release notes are moved up, and as a result the base tag at v0.XX.0 does not contain the release notes.

Reproducible Demo

Can be reproduced by following the steps above.

@hramos
Copy link
Contributor Author

hramos commented Sep 21, 2017

Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally!

If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:

  • Does the issue still reproduce on the latest release candidate? Post a comment with the version you tested.
  • If so, is there any information missing from the bug report? Post a comment with all the information required by the issue template.
  • Is there a pull request that addresses this issue? Post a comment with the PR number so we can follow up.

If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution.

@hramos hramos added the Icebox label Sep 21, 2017
@hramos hramos closed this as completed Sep 21, 2017
@facebook facebook locked as resolved and limited conversation to collaborators Sep 21, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Sep 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

2 participants