-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Systrace is not enabled for JSC on Android #15022
Comments
I have filed a similar issue regarding missing systrace due to fbsystrace.h @ #14394 |
Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally! If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:
If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution. |
Is this a bug report?
Yes
Environment
react-native -v
: 0.46Target Platform: Android
Development Operating System: macOS
Steps to Reproduce
Systrace module in RN depends on hooks like
nativeTraceBeginSection
to exists (see https://github.com/facebook/react-native/blob/master/Libraries/Performance/Systrace.js#L134). But they are added here which isn't run becuase it requiresfbsystrace.h
to exist.nativeTraceBeginSection
and/ornativeTraceBeginSection
WITH_JSC_EXTRA_TRACING
. Fails because it's missingfbsystrace.h
Expected Behavior
Would be really helpful to be able to see what JSC is doing within a systrace on android
The text was updated successfully, but these errors were encountered: