-
Notifications
You must be signed in to change notification settings - Fork 24.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
StyleSheet.flatten is returning frozen object. No need to be frozen, and not documented #15037
Comments
Hi there! This issue is being closed because it has been inactive for a while. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. Either way, we're automatically closing issues after a period of inactivity. Please do not take it personally! If you think this issue should definitely remain open, please let us know. The following information is helpful when it comes to determining if the issue should be re-opened:
If you would like to work on a patch to fix the issue, contributions are very welcome! Read through the contribution guide, and feel free to hop into #react-native if you need help planning your contribution. |
Is this a bug report?
Yes. At the very least, if no one agrees that it "should not be frozen", then the docs need to be updated".
Have you read the Bugs section of the Contributing to React Native Guide?
Yes
Environment
react-native -v
: 0.46.3node -v
: 7.8.0npm -v
: 5.1.0yarn --version
(if you use Yarn): n/aThen, specify:
react-native run-ios
.Steps to Reproduce
(Write your steps here:)
const styles = StyleSheet.create({ text:{ backgroundColor:'red' } });
const flatNew = StyleSheet.flatten(styles.text);
Object.isFrozen(flatNew)
istrue
. There is no need for this freeze. It should be mutable. If you really want it immutable, then docs need update. - http://facebook.github.io/react-native/releases/0.46/docs/stylesheet.html#flattenExpected Behavior
There is no need for this freeze. It should be mutable. If you really want it immutable, then docs need update. - http://facebook.github.io/react-native/releases/0.46/docs/stylesheet.html#flatten
Actual Behavior
Object is frozen, it cannot be mutated.
Reproducible Demo
Link to expo reproducible: https://snack.expo.io/B1A17ZYrZ
The text was updated successfully, but these errors were encountered: