-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TextInput onContentSizeChange wrong content height #15326
Comments
Hey, thanks for reporting this issue! It looks like your description is missing some necessary information, or the list of reproduction steps is not complete. Can you please add all the details specified in the template? This is necessary for people to be able to understand and reproduce the issue being reported. I am going to close this, but feel free to open a new issue with the additional information provided. Thanks! |
Summary: This fixes pretty bad issue when contentSize is calculated based on an intrinsic horizontal (width) limitation, not on a real/current horizontal (width) one. Reviewed By: mmmulani Differential Revision: D5422114 fbshipit-source-id: 0eb582aeb59d29530990d4faabf2f41baa79c058
I'm fairly certain this is a real issue. I'm seeing it crop up after upgrading from 0.46 to 0.47. It looks like 603cc48 address it, but only in 0.48. What do we think about getting this into 0.47 as well? |
@hramos Why this issue was closed? I still see this issue, it brakes auto-expanding text input controls... |
It was merged into 0.47.2 |
@aksonov I explained why the issue was closed above. |
@hramos I've upgraded to 0.47.2 and this is still an issue. |
@chourobin Thanks! It works well for me |
@ChristianTucker shooting in the dark here but are you using cocoa pods? (if so, make sure you pod install to update rn) |
@chourobin Thank you! There's no information on needing to do this in the Upgrade docs. Sometimes I forget the native aspect of react-native. |
TextInput fire onContentSizeChange with wrong content height.
While you typing the text to the half of TextView width (I'm sure that the text still not reach the end of TextInput width by rendering the red background), the onContentSizeChange fire with the new height (of course bigger than the previous height). But the text still not wrap to new line, you can continue typing on the first line.
react-native -v
: 0.47.0Then, specify:
The text was updated successfully, but these errors were encountered: