Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextInput onContentSizeChange wrong content height #15326

Closed
moonjava2005 opened this issue Aug 2, 2017 · 9 comments
Closed

TextInput onContentSizeChange wrong content height #15326

moonjava2005 opened this issue Aug 2, 2017 · 9 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@moonjava2005
Copy link

moonjava2005 commented Aug 2, 2017

TextInput fire onContentSizeChange with wrong content height.
While you typing the text to the half of TextView width (I'm sure that the text still not reach the end of TextInput width by rendering the red background), the onContentSizeChange fire with the new height (of course bigger than the previous height). But the text still not wrap to new line, you can continue typing on the first line.

  1. react-native -v: 0.47.0

Then, specify:

  • Target Platform: iOS 10.3
@hramos
Copy link
Contributor

hramos commented Aug 2, 2017

Hey, thanks for reporting this issue!

It looks like your description is missing some necessary information, or the list of reproduction steps is not complete. Can you please add all the details specified in the template? This is necessary for people to be able to understand and reproduce the issue being reported.

I am going to close this, but feel free to open a new issue with the additional information provided. Thanks!

@hramos hramos closed this as completed Aug 2, 2017
eliperkins referenced this issue Aug 8, 2017
Summary: This fixes pretty bad issue when contentSize is calculated based on an intrinsic horizontal (width) limitation, not on a real/current horizontal (width) one.

Reviewed By: mmmulani

Differential Revision: D5422114

fbshipit-source-id: 0eb582aeb59d29530990d4faabf2f41baa79c058
@eliperkins
Copy link
Contributor

I'm fairly certain this is a real issue. I'm seeing it crop up after upgrading from 0.46 to 0.47. It looks like 603cc48 address it, but only in 0.48. What do we think about getting this into 0.47 as well?

@aksonov
Copy link

aksonov commented Aug 25, 2017

@hramos Why this issue was closed? I still see this issue, it brakes auto-expanding text input controls...

@chourobin
Copy link
Contributor

It was merged into 0.47.2

@hramos
Copy link
Contributor

hramos commented Aug 25, 2017

@aksonov I explained why the issue was closed above.

@ChristianTucker
Copy link

@hramos I've upgraded to 0.47.2 and this is still an issue.

@aksonov
Copy link

aksonov commented Aug 28, 2017

@chourobin Thanks! It works well for me

@chourobin
Copy link
Contributor

@ChristianTucker shooting in the dark here but are you using cocoa pods? (if so, make sure you pod install to update rn)

@ChristianTucker
Copy link

ChristianTucker commented Aug 28, 2017

@chourobin Thank you! There's no information on needing to do this in the Upgrade docs. Sometimes I forget the native aspect of react-native.

@facebook facebook locked as resolved and limited conversation to collaborators Aug 2, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Aug 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

7 participants