-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug / Docs] Usage of nvm is undocumented #15883
Comments
Node 4 is supported, but there's a known issue with how the eslint deps are pulled in that results in an error when npm2 is used (which is the version of npm Node 4 comes with). If we fix that, then the issue you're reporting should go away. See #15821 for discussion. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions. |
Is this a bug report?
Yes.
Have you read the Contributing Guidelines?
Yes.
Environment
react-native -v
: react-native-cli: 2.0.1, react-native: 0.48.2node -v
: v8.4.0npm -v
: 5.3.0yarn --version
: 1.0.1Then, specify:
Steps to Reproduce
(Write your steps here:)
nvm
installed that I'd never removed from my system and it was using Node v4.react-native-xcode.sh
ran, it used the version of node.js provided bynvm
which is different from the default version of node.js on my system that I use for the rest of my development.Expected Behavior
I expected to be told on the command line or in documentation that:
node
or newer is required to support React Native.nvm
is used by the system if it is available. (Either directly installed or viabrew
.)See react-native-xcode.sh.
Actual Behavior
My bundle failed due to using an old version of node via nvm without me knowing. None of the debugging instructions say anything about nvm being used.
I fixed the problem by uninstalling nvm on my system since I haven't been using it in development anymore.
Reproducible Demo
This should be reproducible by installing
nvm
and Node 4.x.I'm not sure of a good way to share a reproducible demo since this is more of an environment configuration issue. I'd expect to occur with the React Native demo app, too.
Next steps
I'm interested in working on a "fix" for this issue by adding some documentation, but I could use some guidance on the best approach. Where in the docs does it make sense to add info about
nvm
?The
react-native-xcode.sh
file doesn't log out anything about the node version being used -- is that something that would make sense to add?The text was updated successfully, but these errors were encountered: