Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android NetworkingModule construct function bug #16084

Closed
dugufei opened this issue Sep 25, 2017 · 1 comment
Closed

Android NetworkingModule construct function bug #16084

dugufei opened this issue Sep 25, 2017 · 1 comment
Labels
Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@dugufei
Copy link

dugufei commented Sep 25, 2017

Is this a bug report?

(write your answer here)
yes

Have you read the Contributing Guidelines?

(Write your answer here.)
yes

Environment

Environment:
OS: macOS Sierra 10.12.6
Node: 8.4.0
Yarn: 1.0.2
npm: 5.4.1
Xcode: Xcode 8.3.3 Build version 8E3004b
Android Studio: 2.3 AI-162.4069837

Packages: (wanted => installed)
react-native: 0.48.1 => 0.48.1
react: 16.0.0-alpha.12 => 16.0.0-alpha.12

Target Platform: Android (7.0)

Steps to Reproduce

(Write your steps here:)

  1. I use custom Okhttpclient in our project in order to print log , and invoke 'OkHttpClientProvider.replaceOkHttpClient()'. However it seems don't work. Then i read the source code and found that construct function of 'com.facebook.react.modules.network.NetworkingModule' use 'OkHttpClientProvider.createClient()' to create okhttpclient rather than 'OkHttpClientProvider.getOkHttpClient()'. As the result ,there are two okhttpclient. Is this a bug or something else ?

Expected Behavior

All of the request is intercept by my custom networkInterceptorCreators.

(Write what you thought would happen.)
the networkInterceptorCreators don't work.

Actual Behavior

the networkInterceptorCreators don't work.

(Write what happened. Add screenshots!)

Reproducible Demo

(Paste the link to an example project and exact instructions to reproduce the issue.)

@stale
Copy link

stale bot commented Nov 24, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Maybe the issue has been fixed in a recent release, or perhaps it is not affecting a lot of people. If you think this issue should definitely remain open, please let us know why. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Nov 24, 2017
@stale stale bot closed this as completed Dec 1, 2017
@facebook facebook locked and limited conversation to collaborators May 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests

1 participant