Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyboardDidShow does not work on Android #17993

Closed
RyanMitchellWilson opened this issue Feb 15, 2018 · 5 comments
Closed

keyboardDidShow does not work on Android #17993

RyanMitchellWilson opened this issue Feb 15, 2018 · 5 comments
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.

Comments

@RyanMitchellWilson
Copy link

I'm trying to set up a Keyboard listener to scroll my list. My code looks like so:

this.keyboardDidShowListener = Keyboard.addListener(
  'keyboardDidShow', () => {
    console.log('Here --> Keyboard did show');
    this.scrollToEnd()
  }
)

This works perfectly in iOS but when I switch over to Android I don't even get the console log, so it is not even calling the callback for keyboardDidShow on Android.

Environment:
OS: macOS High Sierra 10.13.3
Node: 7.5.0
Yarn: Not Found
npm: 4.4.1
Watchman: 4.7.0
Xcode: Xcode 9.2 Build version 9C40b
Android Studio: 3.0 AI-171.4443003

Packages: (wanted => installed)
react: =16.2.0 => 16.2.0
react-native: =0.50.0 => 0.50.0

Target Platform: Android (8.0.0)

I should at least see the console log printing in my console but nothing happens when on Android.

@react-native-bot
Copy link
Collaborator

Thanks for posting this! It looks like your issue is missing some required information. Can you please add all the details specified in the Issue Template? This is necessary for people to be able to understand and reproduce your issue.

I am going to close this, but please feel free to open a new issue with the additional information provided. Thanks!

How to ContributeWhat to Expect from Maintainers

@react-native-bot react-native-bot added no-template Ran Commands One of our bots successfully processed a command. labels Feb 15, 2018
@RyanMitchellWilson
Copy link
Author

Why did this bot just close it, I've got all things needed from the template. Please reopen the issue

@RyanMitchellWilson
Copy link
Author

RyanMitchellWilson commented Feb 15, 2018

@hramos Your bot keeps closing my issue even though I have answered everything that was needed in your template. Why is this happening and can this please get reopened?

@RyanMitchellWilson
Copy link
Author

Ok I finally got one that didn't close automatically, #17995 @hramos You should probably call out the fact that you literally need to keep all the markdown from the template to not have your issue closed. There is not a single place that says that exact structure is required, it just says you "should" follow the template for the best result. It should say you "Must" use the exact structure, because I answered all the questions but since it didn't conform to your template it was automatically closed. Can you please fix your template or your bot so that this is much more clear as to what the user needs to do to actually open an issue? Or maybe instead of just closing it how about marking it as needs-info or something.

@hramos
Copy link
Contributor

hramos commented Feb 16, 2018

The bot isn't quite that advanced, it simply checks that at the very least, the first line from the template is present. I would advise against changing the template, anyway - we go through a lot of issues and it is so much easier to take a look when things are where we expect them to be. Sorry this has caused so much friction.

@facebook facebook locked as resolved and limited conversation to collaborators Feb 15, 2019
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Feb 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

3 participants