Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TextInput value prop break Chinese character input #19104

Closed
3 tasks done
kdong007 opened this issue May 2, 2018 · 13 comments
Closed
3 tasks done

TextInput value prop break Chinese character input #19104

kdong007 opened this issue May 2, 2018 · 13 comments
Labels
Component: TextInput Related to the TextInput component. Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@kdong007
Copy link

kdong007 commented May 2, 2018

Environment

Environment:
OS: macOS High Sierra 10.13.4
Node: 8.9.0
Yarn: 1.5.1
npm: 5.5.1
Watchman: 4.9.0
Xcode: Xcode 9.3 Build version 9E145
Android Studio: 3.0 AI-171.4443003

Packages: (wanted => installed)
react: ^16.3.2 => 16.3.2
react-native: ^0.55.3 => 0.55.3

Steps to Reproduce

export class Test extends React.PureComponent {

    state = {
        text: "",
    };

    render() {
        return (
            <View>
                <Text>test:</Text>
                <TextInput
                    value={this.state.text}
                    onChangeText={text => this.setState({ text })}
                />
            </View>
        );
    }
}

try input some Chinese using soft keyboard

Expected Behavior

Textinput works like Textinput in 0.51

Actual Behavior

Can't select Chinese character from pinyin.
It only works if value={this.state.text} is removed

@react-native-bot react-native-bot added the Component: TextInput Related to the TextInput component. label May 2, 2018
@luchenn
Copy link

luchenn commented May 3, 2018

I have the same issue.

@ihahoo
Copy link

ihahoo commented May 5, 2018

same

@littlewords
Copy link

same in ios

@marcmoo
Copy link

marcmoo commented May 8, 2018

same issue on ios

@tangkunyin
Copy link

@kdong007 It's a bug on iOS
Here is the answer:
#19087
#18874
#18456

@jarvisluong
Copy link

This bug also affects other language as well (in my case Vietnamese)

@yll2wcf
Copy link

yll2wcf commented May 18, 2018

I have the same problem.
react-native: 0.55.4

@wanxsb
Copy link

wanxsb commented May 23, 2018

I have the same problem
react-native: 0.55.4

@thu-san
Copy link

thu-san commented Jun 18, 2018

react-native: 0.55.4 with expo and I tried fixing
#19087
#18874
#18456

but no success.

@heero2801
Copy link

Same problem with Japanese

@woshi82
Copy link

woshi82 commented Jul 19, 2018

I have encounter same problem,I'm using chinese. And this PR work for me. #18456

@stale
Copy link

stale bot commented Dec 21, 2018

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "For Discussion" or "Good first issue" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Dec 21, 2018
@stale
Copy link

stale bot commented Dec 28, 2018

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Dec 28, 2018
@facebook facebook locked as resolved and limited conversation to collaborators Dec 29, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Component: TextInput Related to the TextInput component. Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests