Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursive warning warnings when using Touchables Inspector #20200

Closed
3 tasks done
TheWildUnicorn opened this issue Jul 14, 2018 · 2 comments
Closed
3 tasks done

Recursive warning warnings when using Touchables Inspector #20200

TheWildUnicorn opened this issue Jul 14, 2018 · 2 comments
Labels
Stale There has been a lack of activity on this issue and it may be closed soon.

Comments

@TheWildUnicorn
Copy link

TheWildUnicorn commented Jul 14, 2018

Environment

React Native Environment Info:
System:
OS: macOS High Sierra 10.13.6
CPU: x64 Intel(R) Core(TM) i7-3615QM CPU @ 2.30GHz
Memory: 27.59 MB / 8.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 8.11.3 - /usr/local/bin/node
npm: 5.6.0 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 11.4, macOS 10.13, tvOS 11.4, watchOS 4.3
Android SDK:
Build Tools: 23.0.1, 26.0.1, 26.0.3, 28.0.1
API Levels: 23, 26, 27, 28
IDEs:
Android Studio: 3.1 AI-173.4819257
Xcode: 9.4.1/9F2000 - /usr/bin/xcodebuild
npmPackages:
react: 16.4.1 => 16.4.1
react-native: 0.56.0 => 0.56.0
npmGlobalPackages:
react-native-cli: 2.0.1
react-native-git-upgrade: 0.2.7

Description

The issue is that yellow box warnings can be triggered recursively by other yellow box warnings not having a unique key prop. I discovered this issue in a app that has had significant development, and I decided to test the issue in a brand new React Native app. I started up a brand new React Native 0.56 project using react-native init. When the app gets built onto an iOS (11.4) or Android (API 27) simulator, I can trigger the issue by toggling the inspector, tapping on any element, and then toggling on the "Touchables" feature of the inspector. The result I encounter is several yellow box warnings behind the inspector. Tapping on one of the warnings gives the following information:

screen shot 2018-07-13 at 8 59 52 pm

From what I can tell, the warnings recursively generate themselves. The simulator gradually uses more and more memory, and I haven't been able to dismiss all of the warnings by tapping dismiss on each one individually. If I tap "Dismiss All", all of the warnings are dismissed, and memory usage goes back down. If I disable the "Touchables" feature of the inspector and attempt to replicate the issue in the same instance of the application, it simply doesn't occur. However, if I reload the app on the simulator, I'm able to repeatably reproduce the bug once each time I reload it. I've attached a gif reproducing the issue below.

yellowboxissue_5

Reproducible Demo

I ran react-native init to create this project, and I made zero changes to it before demonstrating the bug. You can find the repo I used to produce this issue here: https://github.com/TheWildUnicorn/RNYellowBoxDemo

Thank you for your time and help!

@stale
Copy link

stale bot commented Oct 12, 2018

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "For Discussion" or "Good first issue" and I will leave it open. Thank you for your contributions.

@stale stale bot added the Stale There has been a lack of activity on this issue and it may be closed soon. label Oct 12, 2018
@stale
Copy link

stale bot commented Oct 19, 2018

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Oct 19, 2018
@facebook facebook locked as resolved and limited conversation to collaborators Oct 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Stale There has been a lack of activity on this issue and it may be closed soon.
Projects
None yet
Development

No branches or pull requests

1 participant