-
Notifications
You must be signed in to change notification settings - Fork 24.2k
-
Notifications
You must be signed in to change notification settings - Fork 24.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some errors are not being handled in NativeModules genMethod #20364
Comments
This sounds like an error with the native code for this method not calling the appropriate callbacks on error. If so, that would mean it is an issue in Expo's native module code. |
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as "For Discussion" or "Good first issue" and I will leave it open. Thank you for your contributions. |
Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information. |
Environment
Description
We believe there is a bug somewhere in
NativeModules
orMessageQueue
modules fromBatchedBridge
library.In our application we are using Expo SDK v. 28.0.0 which maps to React Native 0.55.4. We run into a bug when calling
Expo.FileSystem.downloadAsync
which is indirectly callinggenMethod
fromNativeModules
of React NativeBatchedBridge
library. We are getting a Promise back and we are assigningthen
andcatch
callbacks to the returned promise. Neither of the callbacks is called.We have been able to trace the calls down to
genMethod
function ofNativeModules
module fromreact-native
package and it seems that the problem is rooted there, or more likely somewhere inBatchedBridge
andMessageQueue
modules that are being used there:Here
enqueueNativeCall
method is called and executes without any apparent error, but neither of the callbacks set inenqueueNativeCall
ofNativeModules
are ever called, which in consequence leaves the Promise never resolved.We suspect that we have a bug in our code, specifically we do not ask for permissions to access native API. This however should result in some meaningful error. Instead our async logic flow is just lost without a trace. We believe this is a bug in React Native code rather than Expo.
Reproducible Demo
Application code sample:
The text was updated successfully, but these errors were encountered: