Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use promises on NativeMethodsMixin instead of callbacks #20579

Closed
jgfidelis opened this issue Aug 8, 2018 · 1 comment
Closed

Use promises on NativeMethodsMixin instead of callbacks #20579

jgfidelis opened this issue Aug 8, 2018 · 1 comment
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.

Comments

@jgfidelis
Copy link

jgfidelis commented Aug 8, 2018

Today we use NativeMethodsMixin likes this:

NativeMethodsMixin.measure.call(ref, callback)

We could do something like:

const NativeMethodsMixinAsPromise = (ref) => {
  return new Promise((resolve, reject) => {
    try {
      NativeMethodsMixin.measure.call(ref, (x, y, width, height) => resolve(x, y, width, height))
    } catch (err) {
      reject(err);
    }
  });
}

Something along these lines, so we can use async and await and have a more fluid code.

Can't we make it like this on react-native core?

@react-native-bot
Copy link
Collaborator

We are automatically closing this issue because it does not appear to follow any of the provided issue templates.

Please make use of the bug report template to let us know about a reproducible bug or regression in the core React Native library.

If you'd like to propose a change or discuss a feature request, there is a repository dedicated to Discussions and Proposals you may use for this purpose.

@react-native-bot react-native-bot added Ran Commands One of our bots successfully processed a command. 📋No Template labels Aug 8, 2018
@facebook facebook locked as resolved and limited conversation to collaborators Aug 8, 2019
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Ran Commands One of our bots successfully processed a command. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

2 participants