Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ListView] Exception in renderSectionHeader is overwritten by another one #2069

Closed
grabbou opened this issue Jul 21, 2015 · 7 comments
Closed
Labels
Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Resolution: Locked This issue was locked by the bot.

Comments

@grabbou
Copy link
Contributor

grabbou commented Jul 21, 2015

When in renderSectionHeader of ListView there's an exception (e.g. bad style property), instead of it, another one is being showed:

screen shot 2015-07-21 at 08 46 14

It also looks like ListView keeps looping as the above exception is being printed to the console infinitely.

React 0.7.1

@ericvicenti ericvicenti added the Good first issue Interested in collaborating? Take a stab at fixing one of these issues. label Jul 31, 2015
@ericvicenti
Copy link
Contributor

This would probably make a good first task. Plus it would be great to get more contributors thinking about ListView

@ericvicenti
Copy link
Contributor

Seems similar to #1965 . Leaving both open for now because this is about errors swallowed in renderSectionHeader

@grabbou
Copy link
Contributor Author

grabbou commented Oct 10, 2015

Going to reproduce it on master and if it still happens - will try to make the error better. @ericvicenti definitely, ListViews has always been crucial bits of every iOS application, so the more effort we put into its development the better developer experience we get in the end.

@ide
Copy link
Contributor

ide commented Oct 10, 2015

Thanks @grabbou. I also like that handling the error in JS improves the state of Android too.

@grabbou
Copy link
Contributor Author

grabbou commented Oct 11, 2015

Ok, thanks for the tip 👯

@MattFoley
Copy link

I noticed the other related issues were closed, but on 0.15rc this still seems to be a problem.

@brentvatne
Copy link
Collaborator

Looks like this is a dup of #1379

@facebook facebook locked as resolved and limited conversation to collaborators Jul 22, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Good first issue Interested in collaborating? Take a stab at fixing one of these issues. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

6 participants