Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with inverted props on VirtualizedList #23635

Closed
Sharcoux opened this issue Feb 25, 2019 · 2 comments
Closed

Issues with inverted props on VirtualizedList #23635

Sharcoux opened this issue Feb 25, 2019 · 2 comments
Labels
Component: VirtualizedList Resolution: Locked This issue was locked by the bot. Type: Discussion Long running discussion.

Comments

@Sharcoux
Copy link

The way the current VirtualizedList inverts the elements order is really hacky and generate a lot of troubles, especially when combined with onEndReached events.

You can see the problem here for instance. Sandbox can be found here.

I propose a much simpler and efficient way. But I need some help to complete it. I could test my changes by editing the built file inside the node_modules of the sandboxed project provided above, but I don't know how to build the changes I made in my PR and import them to use them in a sample project...

I'm not sure what should be expected from the "Test Plan" part of the PR.

About the snapshot tests that obviously would fail, should I update them myself?

Tell me what you think.

@hramos
Copy link
Contributor

hramos commented Feb 25, 2019

You can update snapshots if the difference makes sense (it's directly related to your PR). For a test plan, we'd like to hear how you went about testing your changes, did you consider any edge cases, and so on.

@hramos
Copy link
Contributor

hramos commented Feb 26, 2019

Since there's already some discussion on your PR, I think we can close this to avoid duplicate threads.

@hramos hramos closed this as completed Feb 26, 2019
@facebook facebook locked as resolved and limited conversation to collaborators Feb 26, 2020
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Feb 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Component: VirtualizedList Resolution: Locked This issue was locked by the bot. Type: Discussion Long running discussion.
Projects
None yet
Development

No branches or pull requests

3 participants