-
Notifications
You must be signed in to change notification settings - Fork 24.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.60.2] Build failing when enabling Hermes (enableHermes: true) #25599
Comments
This seems to be caused by the hard-coded path to the hermes binary, here: https://github.com/facebook/react-native/blob/0.60-stable/react.gradle#L19 My
|
@bhaskarGyan this issue has been fixed in #25598 |
I have the same error :/ @bhaskarGyan did you solve it? |
cc @bhaskarGyan @burhanyilmaz to fix this issue use the |
@ecreeth I actually just installed 0.60.3 and my build succeeded , but the app crashes on start |
@Karniej The React Native Team, recommend making sure everything works before trying to switch to Hermes. If everything is fine with your application, but with Hermes your application is broken, please send a issue |
I have same issue with
|
@farshidshahmoradi1996 I'm not sure, but I think that before using the command, we must take a few steps before. Here |
@ecreeth, #25598 fix the build issue but now the App is crashing on Startup. I can close this issue if build is working for @farshidshahmoradi1996 |
@bhaskarGyan build is not working in |
There is no problem production and development in my app. But not starting js server when running |
Fixed in 0.60.3. |
Not fixed under windows indeed. |
cc @willholen |
As @farshidshahmoradi1996 said that, while run So I search and download this icu4c-64_2-Win64-MSVC2017.zip, unzip it and put relative dll to \windows folder, then run hermes.exe again, there's no error showing again.
|
investigated some time on it, I found that running hermes.exe need those dlls
and with those dlls in \Windows dir, I can run |
use hermes to compile the bundle file, I can get new bundle file, but with those error logs. Is this means the hermes is not a complete engine for windows?
|
I got error: |
The same issue on I got error: |
Same issue on windows and version 0.60.3
|
modify react.gradle file to add cmd /c before execute hermes can solve the error message. but no matter how, hermes cannot translate some elements as my previous comment is the problem. this makes the return result not zero. then the process stop there. |
0.60.3 same problem: Caused by: net.rubygrapefruit.platform.NativeException: Could not start '....\node_modules\hermesvm\win64-bin\hermes' |
Same here with 0.60.3:
|
Hermes requires the Microsoft Visual C++ 2015 Redistributable, and the ICU4C libraries which were accidentally omitted in the first NPM release (but can be found on the GitHub release). There are undoubtedly several issues at work in this thread though. We're aiming to publish a new NPM this week to address several of them. |
Well I also have issues with
In my react native component I am having this
react-native info
It always outputs |
Thank you soo its working to following these steps. thanks a lot |
I'm really disapointed. |
You are right bro. I am shocking why they have not added new working react.gradle file there with hermes release. We still have to change react.gradle file. If we have to add any package like gmaps etc; then react.gradle file changes again and we have to again modify it. |
Yeah! I was hoping to find a way to prevent |
getting those error logs on mac too. |
The PR fix was merged two days ago: #26556. Hopefully, we will see it in the next update. |
I am using 0.61.2, still I am getting same error of hermes in window... |
I'm still seeing the same error as well in-spite of following the steps mentioned above |
The day my Hermes config works, I will pay myself 2 ice creams. |
It works in ubuntu and not working in window. If I need to reduce the size of apk using hermes, then I need to used ubuntu for that |
@willholen |
Running ./gradlew bundleRelease is giving many similar kind of errors with different variables
Eventhough an app.abb is being created app crashes while running. |
i am using 0.60.5 still facing the issue :( |
Yeah, it was merged to master but that was after the 0.61-branch was cut, so it hasn't made it in a release there. I just added the commit to the request for cherry-picks on 0.61 after seeing @LuigiMaestrelli mention it. I just checked on 0.62-stable and it's on there https://github.com/facebook/react-native/blob/0.62-stable/react.gradle#L153 so whenever 0.62.0 comes out (it's really close but is blocked on CI failures if anyone wants to lend a hand...) it will have it as well. Until then get yourself some patch-package goodness - makes incorporating known fixes in old releases super easy and reliable across all installs of your project :-). Cheers |
@zenz How did this got resolved on mac? |
How did you resolve it? |
Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. You may also label this issue as a "Discussion" or add it to the "Backlog" and I will leave it open. Thank you for your contributions. |
Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information. |
Build is failing when I enable Hermes in android/app/build.gradle
Error:
React Native version:
System:
OS: macOS 10.14.5
CPU: (12) x64 Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz
Memory: 71.63 MB / 16.00 GB
Shell: 3.2.57 - /bin/bash
Binaries:
Node: 10.15.1 - /usr/local/bin/node
Yarn: 1.13.0 - /usr/local/bin/yarn
npm: 6.4.1 - /usr/local/bin/npm
Watchman: 4.9.0 - /usr/local/bin/watchman
SDKs:
iOS SDK:
Platforms: iOS 12.2, macOS 10.14, tvOS 12.2, watchOS 5.2
Android SDK:
API Levels: 23, 24, 25, 26, 27, 28
Build Tools: 21.1.2, 23.0.1, 25.0.0, 25.0.1, 25.0.2, 26.0.2, 26.0.3, 27.0.3, 28.0.0, 28.0.2, 28.0.3, 29.0.0
System Images: android-23 | Intel x86 Atom, android-23 | Google APIs Intel x86 Atom, android-23 | Google APIs Intel x86 Atom_64, android-27 | Android TV Intel x86 Atom, android-27 | Intel x86 Atom, android-27 | Intel x86 Atom_64, android-27 | Google APIs Intel x86 Atom, android-27 | Google Play Intel x86 Atom, android-28 | Intel x86 Atom, android-28 | Intel x86 Atom_64, android-28 | Google APIs Intel x86 Atom, android-28 | Google APIs Intel x86 Atom_64, android-28 | Google Play Intel x86 Atom, android-28 | Google Play Intel x86 Atom_64
Android NDK: 20.0.5594570
IDEs:
Android Studio: 3.4 AI-183.6156.11.34.5522156
Xcode: 10.2/10E125 - /usr/bin/xcodebuild
npmPackages:
react: 16.8.6 => 16.8.6
react-native: 0.60.2 => 0.60.2
npmGlobalPackages:
react-native-cli: 2.0.1
react-native-create-library: 3.1.2
react-native-git-upgrade: 0.2.7
Steps To Reproduce
Describe what you expected to happen:
Build to pass after enabling Hermes
Snack, code example, or link to a repository:
https://github.com/bhaskarGyan/react-native-memory-profile/tree/bug/rn-0.60.2_hermes
The text was updated successfully, but these errors were encountered: