Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.13] Planning the next RC #3291

Closed
7 of 9 tasks
ide opened this issue Oct 8, 2015 · 14 comments
Closed
7 of 9 tasks

[0.13] Planning the next RC #3291

ide opened this issue Oct 8, 2015 · 14 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@ide
Copy link
Contributor

ide commented Oct 8, 2015

@mkonicek is on 0.12 and we'll cut 0.13-rc soon after. Here are the main bugs that are holding up the release:

General:

iOS:

Android:

Infra:

  • Packager has a syntax error due to not being transformed in some cases: [PACKAGER] Current master does not successfully start packager. #3262, @martinbigio says fix coming soon
  • Test the basic workflow on Windows even if everything doesn't work like the Chrome debugger. After discussing with @mkonicek we're going to start with Windows support being a Community Responsibility and communicate that clearly. The best Windows support is going to come from people developing with RN master and using Windows on a daily basis so if someone wants to step up to the plate we can work with them on that. People are helping in [Windows] Testing master on Windows 10 #3348.
  • Rudimentary npm 3 support. We should get things to work even if the state of npm 3 isn't great. I believe there's a huge perf regression (may be fixed!) so most core devs are sticking with npm 2 but if it's not too hard to get npm 3 to be useable let's do that. [npm 3] Get the packager and CLI to work with npm 3 #3317

It would be nice if we could include the AAR/JAR files with the npm distribution but it's not a launch blocker. Perhaps we could do that for 0.13 or 0.14-rc.

I'll take care of drafting the changelog.

@mkonicek
Copy link
Contributor

mkonicek commented Oct 9, 2015

@ide What is needed for npm 3 support? There's been one fix for npm 3: daba142?

@ide
Copy link
Contributor Author

ide commented Oct 9, 2015

@mkonicek I haven't looked into npm 3 at all, but I'm hoping that it will be just one or two fixes for things to start working.

@Sinewyk
Copy link

Sinewyk commented Oct 9, 2015

Just saying that the npm3 perf regression (making it almost unuseable) has been fixed in npm https://github.com/npm/npm/releases/tag/v3.3.6 release. It's still a bit slower (by seconds) because it's doing a lot more work, but not by an order of magnitude like before (40-50x slower).

@mikearmstrong001
Copy link
Contributor

#3082 @tadeuzagallo has added a comment, he is looking for repro steps as was unable to recreate

@ide
Copy link
Contributor Author

ide commented Oct 9, 2015

Re #3082 you need an actual device with the pressure sensors to repro. Wasn't sure if they have 6s's yet. (If not -- here's something to write in a request ticket :)

@gre
Copy link
Contributor

gre commented Oct 10, 2015

I'm sorry this might not be the right place but I don't know where else to ask,

When do you guys plan to depend on react 0.14+ so we can write "universal" libraries that depends on react and works both on react-dom and react-native ?

@ide
Copy link
Contributor Author

ide commented Oct 10, 2015

@gre it is planned but no ETA: #2985.

@gre
Copy link
Contributor

gre commented Oct 10, 2015

Thanks :)

@ide
Copy link
Contributor Author

ide commented Oct 11, 2015

I only have a Windows 8 VM and it's waiting in line for the Windows 10 upgrade. Opened #3348 so people interested in Windows support can help get it in for the next release.

@mkonicek
Copy link
Contributor

I propose we cut the 0.13 branch now.

Checked with @tadeuzagallo, #3082 is going to take a while, we should cherry-pick it.
Likewise, can cherry-pick Windows-related fixes.

Want to cut the branch now when things are in a good state after the tests and packager fixes from end of last week. There's always a new release every two weeks and we can cherry-pick important fixes into 0.13.

@ide
Copy link
Contributor Author

ide commented Oct 12, 2015

Sounds good. From #3348 it sounds like Windows might already work once we publish the 0.13-rc JAR and we can add other features like Chrome debugger support in 0.14 or 0.15.

@ide
Copy link
Contributor Author

ide commented Oct 12, 2015

iOS UIExplorer and Android UIExplorer + Movies App (from source) work on 0.13-stable. So we need to build the Android libs, upload them, and then follow up with the people helping test initial Windows support and can release the RC.

@mkonicek
Copy link
Contributor

Good news! :) Just released 0.13.0-rc to npm, CocoaPods and JCenter.

@ide
Copy link
Contributor Author

ide commented Oct 13, 2015

Thanks @mkonicek!

@ide ide closed this as completed Oct 13, 2015
@facebook facebook locked as resolved and limited conversation to collaborators Jul 21, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

7 participants