Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fabric is not The effect on Android FlatList #33943

Closed
bozaigao opened this issue Jun 1, 2022 · 7 comments
Closed

Fabric is not The effect on Android FlatList #33943

bozaigao opened this issue Jun 1, 2022 · 7 comments
Labels
Component: FlatList Impact: Performance When the issue impacts the app running or build performance Needs: Attention Issues where the author has responded to feedback. Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. Platform: Android Android applications. Type: New Architecture Issues and PRs related to new architecture (Fabric/Turbo Modules)

Comments

@bozaigao
Copy link

bozaigao commented Jun 1, 2022

Description

When I turned on the Fabric switch on the Android terminal, I used the FlatList to render the long list of data, and the rendering was blank and the frame was dropped when I slid quickly

1654074005778559.mp4

Version

0.68.2

Output of npx react-native info

use RN 0.68.2

Steps to reproduce

use RN 0.68.2

Snack, code example, screenshot, or link to a repository

use RN 0.68.2

@bozaigao bozaigao added Needs: Triage 🔍 Type: New Architecture Issues and PRs related to new architecture (Fabric/Turbo Modules) labels Jun 1, 2022
@cortinico
Copy link
Contributor

use RN 0.68.2

Could you share you repro?

@cortinico cortinico added Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. Impact: Performance When the issue impacts the app running or build performance and removed Needs: Triage 🔍 labels Jun 1, 2022
@github-actions
Copy link

github-actions bot commented Jun 1, 2022

⚠️ Missing Reproducible Example
ℹ️ It looks like your issue is missing a reproducible example. Please provide a Snack or a repository that demonstrates the issue you are reporting in a minimal, complete, and reproducible manner.

@bozaigao
Copy link
Author

bozaigao commented Jun 2, 2022

@cortinico the repo url:https://github.com/bozaigao/FabircFlatListDemo, On Android I just set the newArchEnabled true and used the FlatList to render the long list

@github-actions github-actions bot added Needs: Attention Issues where the author has responded to feedback. and removed Needs: Author Feedback labels Jun 2, 2022
@bozaigao
Copy link
Author

bozaigao commented Jun 3, 2022

@cortinico What causes this problem? Frames should not drop when rendering synchronously with fabric,Or am I not configured somewhere?

@sammy-SC
Copy link
Contributor

Hello @bozaigao,

to clarify, you expect synchronous rendering to prevent white patches from appearing in flat list, is that correct?

If that's the case, that behaviour has not been implemented yet. FlatList, nor any other place in React Native, does not leverage synchronous rendering yet. The new architecture is an important milestone towards synchronous rendering but the capability is not in production at the moment.

I'm going to close this issue as the behaviour you are seeing is expected. Let me know if you have questions.

@HuJean
Copy link

HuJean commented Jan 3, 2023

Hello @bozaigao,

to clarify, you expect synchronous rendering to prevent white patches from appearing in flat list, is that correct?

If that's the case, that behaviour has not been implemented yet. FlatList, nor any other place in React Native, does not leverage synchronous rendering yet. The new architecture is an important milestone towards synchronous rendering but the capability is not in production at the moment.

I'm going to close this issue as the behaviour you are seeing is expected. Let me know if you have questions.

When will synchronous rendering be implemented?

@sammy-SC
Copy link
Contributor

sammy-SC commented Feb 8, 2023

hey,

some parts of it are already in the codebase, for example https://github.com/facebook/react-native/blob/main/Libraries/Components/TextInput/TextInput.js#L741

we haven't settled on how to bring synchronous rendering to React Native yet and are still iterating on it. It is challenging to make it performant and backwards compatible at the same time and evaluating what the options are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: FlatList Impact: Performance When the issue impacts the app running or build performance Needs: Attention Issues where the author has responded to feedback. Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. Platform: Android Android applications. Type: New Architecture Issues and PRs related to new architecture (Fabric/Turbo Modules)
Projects
None yet
Development

No branches or pull requests

5 participants