Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the support for the inline code blocks #42602

Closed
cubuspl42 opened this issue Jan 22, 2024 · 10 comments
Closed

Implement the support for the inline code blocks #42602

cubuspl42 opened this issue Jan 22, 2024 · 10 comments
Assignees
Labels
Never gets stale Prevent those issues and PRs from getting stale Type: Enhancement A new feature or enhancement of an existing feature.

Comments

@cubuspl42
Copy link
Contributor

cubuspl42 commented Jan 22, 2024

Description

Implement the support for the inline code blocks, as proposed here: react-native-community/discussions-and-proposals#695

Copy link

⚠️ Newer Version of React Native is Available!
ℹ️ You are on a supported minor version, but it looks like there's a newer patch available - 0.73.2. Please upgrade to the highest patch for your minor or latest and verify if the issue persists (alternatively, create a new project and repro the issue in it). If it does not repro, please let us know so we can close out this issue. This helps us ensure we are looking at issues that still exist in the most recent releases.

@github-actions github-actions bot added Newer Patch Available Needs: Author Feedback Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. labels Jan 22, 2024
Copy link

⚠️ Missing Reproducible Example
ℹ️ We could not detect a reproducible example in your issue report. Please provide either:
  • If your bug is UI related: a Snack
  • If your bug is build/update related: use our Reproducer Template. A reproducer needs to be in a GitHub repository under your username.

@cubuspl42
Copy link
Contributor Author

cubuspl42 commented Jan 22, 2024

@cortinico I think we could...

...add labels "Type: Enhancement", "Tech: Fabric", "Tech: React Native Core"
...remove all other labels

I hope that we won't get into a fight with bots thinking that this is a bug!

@github-actions github-actions bot added Needs: Attention Issues where the author has responded to feedback. and removed Needs: Author Feedback labels Jan 22, 2024
@cortinico cortinico added Type: Enhancement A new feature or enhancement of an existing feature. Never gets stale Prevent those issues and PRs from getting stale and removed Needs: Triage 🔍 Needs: Repro This issue could be improved with a clear list of steps to reproduce the issue. Newer Patch Available Needs: Attention Issues where the author has responded to feedback. labels Jan 22, 2024
@cubuspl42
Copy link
Contributor Author

cubuspl42 commented Jan 23, 2024

The first big step in this project was de-duplicating various paths for building Spannable objects on Android:

This PR is now merged!

Remaining actions:

  • Launch an A/B test to verify this functionality
  • Analyze the results from the A/B test (March/June/July)
  • Delete the code left-overs from the A/B test

@cubuspl42
Copy link
Contributor Author

cubuspl42 commented Jan 23, 2024

@cubuspl42
Copy link
Contributor Author

PR with the initial feature implementation:

@krishpranav
Copy link

Hi, is this still open? I am looking to work on some issues.

@cubuspl42
Copy link
Contributor Author

@krishpranav

#39630 was reverted because of some performance regressions on production for Meta apps (these were measured by Meta using their internal tools).

I'm no longer working on this project. Long story short, the Android text subsystem in React Native is not in very good shape and some of the folks who originally implemented it no longer work for Meta. Doing significant changes in that subsystem from outside of Meta is unrealistic; believe me, I tried to move mountains.

For now, I'll close this.

@krishpranav
Copy link

okay cool np.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Never gets stale Prevent those issues and PRs from getting stale Type: Enhancement A new feature or enhancement of an existing feature.
Projects
None yet
Development

No branches or pull requests

3 participants