-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ReactNative 0.73 did not include the Hermes WeakMap memory leak fix #42620
Labels
Comments
|
|
github-actions
bot
added
Needs: Author Feedback
Needs: Repro
This issue could be improved with a clear list of steps to reproduce the issue.
labels
Jan 23, 2024
edkimmel
changed the title
ReactNative 0.73 did not include the WeakMap memory leak fix
ReactNative 0.73 did not include the Hermes WeakMap memory leak fix
Jan 23, 2024
Closing as you should ask for this pick here: The change doesn't look that invasive so we should be able to pick it. However we'll need to get a confirmation from @neildhar @tmikov that it's safe to pick this change on for 0.73. |
cortinico
added
Resolution: Answered
When the issue is resolved with a simple answer
and removed
Needs: Triage 🔍
Needs: Author Feedback
Needs: Repro
This issue could be improved with a clear list of steps to reproduce the issue.
labels
Jan 23, 2024
Confirming that this is safe to pick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Description
It looks like ReactNative 0.73 took a build of hermes from September 2023. The WeakMap memory leak was fixed in November. facebook/hermes@e7b2abe
Would it be possible to get a minor version / hotfix built of 0.73 to include that fix? Right now, our choices are to patch and host a custom hermes ourselves or to continue to call GC manually to work around the issue.
Steps to reproduce
facebook/hermes@e7b2abe
React Native Version
0.73.0
Affected Platforms
Runtime - Android, Runtime - iOS
Output of
npx react-native info
Stacktrace or Logs
Reproducer
facebook/hermes@e7b2abe
Screenshots and Videos
No response
The text was updated successfully, but these errors were encountered: