Correct message annotation on early js errors #47889
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66316907 |
RSNara
force-pushed
the
export-D66316907
branch
from
5806f33
to
98c69da
Compare
Summary: ## Context When is the runtime ready? - After the main bundle finishes executing **without** raising a fatal javascript error ## Changes Let's decorate all errors reported while the runtime is not ready as "[runtime not ready]". Changelog: [Internal] Reviewed By: mdvacca Differential Revision: D66316907
RSNara
force-pushed
the
export-D66316907
branch
from
98c69da
to
da29b6d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66316907 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D66316907 |
|
This pull request has been merged in e4d8c96. |
|
This pull request was successfully merged by @RSNara in e4d8c96 When will my fix make it into a release? | How to file a pick request? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Context
When is the runtime ready?
Changes
Let's decorate all errors reported while the runtime is not ready as "[runtime not ready]".
Long-term, I think we should find a better way to annotate these errors. (Modifying the error message is probably subpar, from a server-side analysis standpoint). I will look into that.
Changelog: [Internal]
Differential Revision: D66316907