Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StyleSheet.fullScreen is not compatible with React 15.3.0 #9093

Closed
steida opened this issue Jul 29, 2016 · 12 comments
Closed

StyleSheet.fullScreen is not compatible with React 15.3.0 #9093

steida opened this issue Jul 29, 2016 · 12 comments
Labels
Resolution: Locked This issue was locked by the bot.

Comments

@steida
Copy link

steida commented Jul 29, 2016

Warning: You are manually calling a React.PropTypes validation function for the 'bottom' prop on 'StyleSheet.fullScreen'. This is deprecated...

@marcusmotill
Copy link

Experiencing this on react 15.2.0 and react-native 0.30.0

@neiker
Copy link

neiker commented Jul 31, 2016

Same here, see this issue in React:
facebook/react#7131
And the corresponding PR:
facebook/react#7132

I suggest you to downgrade to react 15.2.1 until RN support react 15.3.0

@satya164
Copy link
Contributor

@neiker I suggest you to downgrade to react 15.2.1 until RN support react 15.3.0

Isn't this just an warning? No need to downgrade.

@mehcode
Copy link
Contributor

mehcode commented Jul 31, 2016

It's a very annoying warning (I get about about a 1000 yellow boxes every reload). Enough to make me downgrade unless there was something super nice in 15.3.x I wanted and even then I'd probably fork react to make it stop warning me.

@steida
Copy link
Author

steida commented Jul 31, 2016

@mehcode Easy fix: https://github.com/este/este/blob/617441c75ecf0a0262c06f34dcda1a66b4b8dddc/src/native/index.js#L5

@fabriziomoscon
Copy link

@satya164 this is a big deal for development experience because with 1000 yellow boxes every little step in development takes 10 seconds. I understand there are workarounds but if I can express my thoughts this is a deal breaker for upgrading.

@neiker
Copy link

neiker commented Jul 31, 2016

@satya164 yeah, it's just a warning, but a really annoying one.

@steida
Copy link
Author

steida commented Jul 31, 2016

Common, you can hide one warning easily via console.ignoredYellowBox

@satya164
Copy link
Contributor

satya164 commented Aug 1, 2016

this is a big deal for development experience because with 1000 yellow boxes every little step in development takes 10 seconds.

You can hide the specific warning by following the steps here -

* Warnings can be ignored programmatically by setting the array:

@satya164
Copy link
Contributor

satya164 commented Aug 1, 2016

Also would be nice if someone can send a PR to fix this issue in RN core.

@neiker
Copy link

neiker commented Aug 1, 2016

Is fixed in next version

5db5ee9

Meanwhile, I added this to my index.ios.js as @steida suggested before

// eslint-disable-next-line no-console
console.ignoredYellowBox = [
  // https://github.com/facebook/react-native/issues/9093
  'Warning: You are manually calling a React.PropTypes validation',
];

@satya164
Copy link
Contributor

satya164 commented Aug 1, 2016

@neiker Thanks. Closing this then.

@satya164 satya164 closed this as completed Aug 1, 2016
@facebook facebook locked as resolved and limited conversation to collaborators May 24, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

7 participants