-
Notifications
You must be signed in to change notification settings - Fork 24.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WebView] Allow passing allowsInlineMediaPlayback as a boolean #960
Comments
@jonathanong - can you create a PR for this? seems like a simple change, you can refer to the recently pushed Native UI Components guide or ping me on irc @notbrent if you need a hand. |
Could you please show me where to add this in RTCWebView.m? Thanks |
@erikdung - you can add that here: https://github.com/facebook/react-native/blob/master/React/Views/RCTWebView.m#L39 - but preferably we would have an option that we could just pass into the component to enable/disable that, I can do this later |
Great. Thanks. I solved my problem when creating app with youtube videos. I disabled fullscreen mode. |
Thank you for reporting this issue and appreciate your patience. We've notified the core team for an update on this issue. We're looking for a response within the next 30 days or the issue may be closed. |
+1 can we make this happen? also while you're on it, could you add an option for |
@madrabbit - PR welcome! |
7da42e3 added option for @jonathanong closing this in favor of that commit. Let me know if we need to reopen this. @madrabbit Can you open a separate issue for |
currently doing adding
_webView.allowsInlineMediaPlayback = YES;
inRCTWebView.m
to get around this.https://developer.apple.com/library/ios/documentation/UIKit/Reference/UIWebView_Class/#//apple_ref/occ/instp/UIWebView/allowsInlineMediaPlayback
The text was updated successfully, but these errors were encountered: