Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image was partially loaded but onLoad was called and onError (on iOS) was not called #9893

Closed
xzdev opened this issue Sep 14, 2016 · 9 comments
Labels
Platform: iOS iOS applications. Resolution: Locked This issue was locked by the bot.

Comments

@xzdev
Copy link

xzdev commented Sep 14, 2016

Issue Description

When using multiple <Image source='http://someImagePath' /> to load a bunch of network images, some user interaction triggers a navigation update which loads new scene to the top. When coming back to the previous scene, a few of images were partially loaded (as shown in the following picture).

screen shot 2016-09-14 at 2 13 20 am

Adding onLoad and onError (on iOS) to debug, I found onLoad was called and onError was never triggered. That means the broken image was considered as loaded successfully. As the partially loaded images were cached, even triggering another render will still show the broken images.

The issue was recently introduced around 0.28 and it is reproducible on the build 0.32 and 0.33.

Is there anyone who have the similar issue?

Additional Information

  • React Native version: [0.32 & 0.33]
  • Platform(s) (iOS, Android, or both?): [both]
  • Operating System (macOS, Linux, or Windows?): [macOS]
@bitcoinvsalts
Copy link

+1

@wcandillon
Copy link
Contributor

@xzdev Does this happens with remote image? This issue only happens to me for images which I save to the filesystem.

@xzdev
Copy link
Author

xzdev commented Feb 8, 2017

Yes. It happens to me with remote images. It happens when there are multiple remote images loading concurrently and immediately navigate to a new scene. The issue did not occur again on my 6+ after upgrading to the latest IOS.

@relaxedtomato
Copy link

Has anyone found a resolution to this - I am noticing this on iOS 9 at the moment.

@relaxedtomato
Copy link

relaxedtomato commented Feb 22, 2017

@jsappme, @wcandillon - did you research this bug further?

cc: @ptmt @mihailmetro

@bitcoinvsalts
Copy link

@r-bansal I was using a buggy image cache module

@wcandillon
Copy link
Contributor

@r-bansal same for me!

@wcandillon
Copy link
Contributor

wcandillon commented Apr 15, 2017

@r-bansal @xzdev You can find more details about why this happens at wkh237/react-native-fetch-blob#331. This use case is supported in https://github.com/wcandillon/react-native-img-cache.

@shergin I think this issue can be closed.

@shergin shergin closed this as completed Apr 19, 2017
@shergin
Copy link
Contributor

shergin commented Apr 19, 2017

@xzdev You are using react-native-img-cache, right?

@facebook facebook locked as resolved and limited conversation to collaborators Jul 19, 2018
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label Jul 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Platform: iOS iOS applications. Resolution: Locked This issue was locked by the bot.
Projects
None yet
Development

No branches or pull requests

6 participants