Remove PassiveStatic optimization

Passive flags are a new concept that is tricky to get right. We've already found two bugs related to PassiveStatic. Let's remove this optimization for now, and add it back once the main part of the effects refactor lands.
facebook · Dec 18, 2020 · 00a5b08 · 00a5b08
1 parent a6329b1
commit 00a5b08
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 14 deletions.
diff --git a/packages/react-reconciler/src/ReactFiberCommitWork.new.js b/packages/react-reconciler/src/ReactFiberCommitWork.new.js
@@ -70,7 +70,6 @@ import {
  Snapshot,
  Update,
  Passive,
- PassiveStatic,
  PassiveMask,
  PassiveUnmountPendingDev,
 } from './ReactFiberFlags';
@@ -2007,7 +2006,8 @@ function commitPassiveUnmountEffectsInsideOfDeletedTree_begin(
  while (nextEffect !== null) {
  const fiber = nextEffect;
  const child = fiber.child;
- if ((fiber.subtreeFlags & PassiveStatic) !== NoFlags && child !== null) {
+ // TODO: Only traverse subtree if it has a PassiveStatic flag
+ if (child !== null) {
  ensureCorrectReturnPointer(child, fiber);
  nextEffect = child;
  } else {
@@ -2023,11 +2023,10 @@ function commitPassiveUnmountEffectsInsideOfDeletedTree_complete(
 ) {
  while (nextEffect !== null) {
  const fiber = nextEffect;
- if ((fiber.flags & PassiveStatic) !== NoFlags) {
- setCurrentDebugFiberInDEV(fiber);
- commitPassiveUnmountInsideDeletedTreeOnFiber(fiber);
- resetCurrentDebugFiberInDEV();
- }
+ // TODO: Check if fiber has a PassiveStatic flag
+ setCurrentDebugFiberInDEV(fiber);
+ commitPassiveUnmountInsideDeletedTreeOnFiber(fiber);
+ resetCurrentDebugFiberInDEV();
 
  if (fiber === deletedSubtreeRoot) {
  nextEffect = null;

diff --git a/packages/react-reconciler/src/ReactFiberCommitWork.old.js b/packages/react-reconciler/src/ReactFiberCommitWork.old.js
@@ -70,7 +70,6 @@ import {
  Snapshot,
  Update,
  Passive,
- PassiveStatic,
  PassiveMask,
  PassiveUnmountPendingDev,
 } from './ReactFiberFlags';
@@ -2007,7 +2006,8 @@ function commitPassiveUnmountEffectsInsideOfDeletedTree_begin(
  while (nextEffect !== null) {
  const fiber = nextEffect;
  const child = fiber.child;
- if ((fiber.subtreeFlags & PassiveStatic) !== NoFlags && child !== null) {
+ // TODO: Only traverse subtree if it has a PassiveStatic flag
+ if (child !== null) {
  ensureCorrectReturnPointer(child, fiber);
  nextEffect = child;
  } else {
@@ -2023,11 +2023,10 @@ function commitPassiveUnmountEffectsInsideOfDeletedTree_complete(
 ) {
  while (nextEffect !== null) {
  const fiber = nextEffect;
- if ((fiber.flags & PassiveStatic) !== NoFlags) {
- setCurrentDebugFiberInDEV(fiber);
- commitPassiveUnmountInsideDeletedTreeOnFiber(fiber);
- resetCurrentDebugFiberInDEV();
- }
+ // TODO: Check if fiber has a PassiveStatic flag
+ setCurrentDebugFiberInDEV(fiber);
+ commitPassiveUnmountInsideDeletedTreeOnFiber(fiber);
+ resetCurrentDebugFiberInDEV();
 
  if (fiber === deletedSubtreeRoot) {
  nextEffect = null;