Skip to content

Commit

Permalink
Added missing feature flag
Browse files Browse the repository at this point in the history
  • Loading branch information
Brian Vaughn committed Feb 18, 2020
1 parent 691096c commit 14afeb1
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions packages/shared/forks/ReactFeatureFlags.testing.www.js
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ export const disableUnstableRenderSubtreeIntoContainer = __EXPERIMENTAL__;
export const warnUnstableRenderSubtreeIntoContainer = false;
export const disableUnstableCreatePortal = __EXPERIMENTAL__;
export const deferPassiveEffectCleanupDuringUnmount = false;
export const runAllPassiveEffectDestroysBeforeCreates = false;

This comment has been minimized.

Copy link
@acdlite

acdlite Feb 18, 2020

Collaborator

Did you mean to make this a dynamic flag?

This comment has been minimized.

Copy link
@acdlite

acdlite Feb 18, 2020

Collaborator

Oh, this is the testing build.

This comment has been minimized.

Copy link
@bvaughn

bvaughn Feb 18, 2020

Contributor

Yeah, it's dynamic for the main www flags:

runAllPassiveEffectDestroysBeforeCreates,

export const isTestEnvironment = true;

// Only used in www builds.
Expand Down

0 comments on commit 14afeb1

Please sign in to comment.