Skip to content

Commit 16c78d7

Browse files
committed
[react-dom] Fire onReset when automatically resetting forms
1 parent 780e091 commit 16c78d7

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

packages/react-dom-bindings/src/client/ReactFiberConfigDOM.js

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6466,5 +6466,7 @@ export const HostTransitionContext: ReactContext<TransitionStatus> = {
64666466

64676467
export type FormInstance = HTMLFormElement;
64686468
export function resetFormInstance(form: FormInstance): void {
6469+
ReactBrowserEventEmitterSetEnabled(true);
64696470
form.reset();
6471+
ReactBrowserEventEmitterSetEnabled(false);
64706472
}

packages/react-dom/src/__tests__/ReactDOMForm-test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1630,10 +1630,10 @@ describe('ReactDOMForm', () => {
16301630
// We haven't reset yet.
16311631
expect(inputRef.current.value).toEqual('3');
16321632

1633-
// Action completes. onReset hasn't fired though.
1633+
// Action completes. onReset has been fired and values reset manually.
16341634
await act(() => resolveText('Wait'));
16351635
assertLog([]);
1636-
expect(inputRef.current.value).toEqual('3');
1636+
expect(inputRef.current.value).toEqual('0');
16371637
});
16381638

16391639
it('requestFormReset schedules a form reset after transition completes', async () => {

0 commit comments

Comments
 (0)