Skip to content

Commit 1b5ca99

Browse files
authored
Fix module ID deduplication (#20406)
1 parent 5fd9db7 commit 1b5ca99

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

Diff for: packages/react-server/src/ReactFlightServer.js

+3-1
Original file line numberDiff line numberDiff line change
@@ -432,7 +432,8 @@ export function resolveModelToJSON(
432432
if (isModuleReference(value)) {
433433
const moduleReference: ModuleReference<any> = (value: any);
434434
const moduleKey: ModuleKey = getModuleKey(moduleReference);
435-
const existingId = request.writtenModules.get(moduleKey);
435+
const writtenModules = request.writtenModules;
436+
const existingId = writtenModules.get(moduleKey);
436437
if (existingId !== undefined) {
437438
return serializeByValueID(existingId);
438439
}
@@ -444,6 +445,7 @@ export function resolveModelToJSON(
444445
request.pendingChunks++;
445446
const moduleId = request.nextChunkId++;
446447
emitModuleChunk(request, moduleId, moduleMetaData);
448+
writtenModules.set(moduleKey, moduleId);
447449
if (parent[0] === REACT_ELEMENT_TYPE && key === '1') {
448450
// If we're encoding the "type" of an element, we can refer
449451
// to that by a lazy reference instead of directly since React

0 commit comments

Comments
 (0)