[WIP] Get the before and after for the build results

Author: orta

dangerfile.js

@@ -9,15 +9,38 @@
 
 'use strict';
 
-const { danger, markdown, warn } = require('danger');
+const { danger, markdown, schedule } = require('danger');
 
-// Tags big PRs
-var bigPRThreshold = 600;
-if (danger.git.modified_files + danger.git.added_files + danger.git.deleted_files > bigPRThreshold) {
-  const title = ':exclamation: Big PR';
-  const files = danger.git.modified_files + danger.git.added_files + danger.git.deleted_files;
-  const idea = `This PR is extremely unlikely to get reviewed because it touches ${files} files.`;
-  warn(`${title} - <i>${idea}</i>`);
+const { resultsHeaders, generateResultsArray, currentBuildResults } = require('./scripts/rollup/stats');
 
-  markdown('@facebook-github-bot large-pr');  
+/**
+ * Generates a Markdown table
+ * @param {string[]} headers 
+ * @param {string[][]} body 
+ */
+function generateMDTable(headers, body) {
+  const tableHeaders = [
+    headers.join(' | '), 
+    headers.map(() => ' --- ').join(' | '),
+  ];
+
+  const tablebody = body.map(r => r.join(' | '));
+  return tableHeaders.join('\n') + '\n' + tablebody.join('\n');
 }
+
+// Grab the results.json before we ran CI via the GH API
+const getJSON = danger.github.utils
+  .fileContents('scripts/rollup/results.json');
+
+// @bug See https://github.com/danger/danger-js/issues/443
+schedule(getJSON);
+getJSON.then(APIPreviousBuildResults => {
+  const previousBuildResults = JSON.parse(APIPreviousBuildResults);
+  const results = generateResultsArray(currentBuildResults, previousBuildResults);
+
+  markdown('### Bundle Changes:\n');
+  // const percentToWarrentShowing = 0.1
+  // const onlyResultsToShow = results.filter(f => Math.abs(f[3]) > percentToWarrentShowing);
+
+  markdown(generateMDTable(resultsHeaders, results));
+});

scripts/circleci/test_entry_point.sh

@@ -26,6 +26,7 @@ if [ $((2 % CIRCLE_NODE_TOTAL)) -eq "$CIRCLE_NODE_INDEX" ]; then
   COMMANDS_TO_RUN+=('yarn test-build --runInBand')
   COMMANDS_TO_RUN+=('node ./scripts/tasks/danger')
   COMMANDS_TO_RUN+=('yarn test-build-prod --runInBand')
+  COMMANDS_TO_RUN+=('node ./scripts/tasks/danger')
   COMMANDS_TO_RUN+=('./scripts/circleci/upload_build.sh')
 fi
 

scripts/rollup/results.json

@@ -400,4 +400,4 @@
       "gzip": 525
     }
   ]
-}
+}

scripts/rollup/stats.js

@@ -20,37 +20,35 @@ function saveResults() {
   );
 }
 
+
 function percentChange(prev, current) {
-  const change = Math.floor((current - prev) / prev * 100);
+  return Math.floor((current - prev) / prev * 100);
+}
 
+function percentChangeString(change) {
   if (change > 0) {
     return chalk.red.bold(`+${change} %`);
   } else if (change <= 0) {
     return chalk.green.bold(change + ' %');
   }
 }
 
-function printResults() {
-  const table = new Table({
-    head: [
-      chalk.gray.yellow('Bundle'),
-      chalk.gray.yellow('Prev Size'),
-      chalk.gray.yellow('Current Size'),
-      chalk.gray.yellow('Diff'),
-      chalk.gray.yellow('Prev Gzip'),
-      chalk.gray.yellow('Current Gzip'),
-      chalk.gray.yellow('Diff'),
-    ],
-  });
-  currentBuildResults.bundleSizes.forEach(result => {
-    const matches = prevBuildResults.bundleSizes.filter(
-      ({filename, bundleType}) =>
-        filename === result.filename && bundleType === result.bundleType
-    );
-    if (matches.length > 1) {
-      throw new Error(`Ambiguous bundle size record for: ${result.filename}`);
-    }
-    const prev = matches[0];
+const resultsHeaders = [
+  'Bundle',
+  'Prev Size',
+  'Current Size',
+  'Diff',
+  'Prev Gzip',
+  'Current Gzip',
+  'Diff',
+];
+
+function generateResultsArray(current, prevResults) {
+  currentBuildResults.bundleSizes.forEach(index => {
+    const result = currentBuildResults.bundleSizes[index];
+    const prev = prevBuildResults.bundleSizes.filter(
+      res => res.filename === result.filename
+    )[0];
     if (result === prev) {
       // We didn't rebuild this bundle.
       return;
@@ -60,21 +58,45 @@ function printResults() {
     const gzip = result.gzip;
     let prevSize = prev ? prev.size : 0;
     let prevGzip = prev ? prev.gzip : 0;
-    table.push([
-      chalk.white.bold(`${result.filename} (${result.bundleType})`),
-      chalk.gray.bold(filesize(prevSize)),
-      chalk.white.bold(filesize(size)),
+
+    return [
+      `${result.filename} (${result.bundleType}`, 
+      filesize(prevSize),
+      filesize(size),
       percentChange(prevSize, size),
-      chalk.gray.bold(filesize(prevGzip)),
-      chalk.white.bold(filesize(gzip)),
+      filesize(prevGzip),
+      filesize(gzip),
       percentChange(prevGzip, gzip),
+    ];
+  // Strip any nulls
+  }).filter(f => f);
+}
+
+function printResults() {
+  const table = new Table({
+    head: resultsHeaders.map(chalk.gray.yellow),
+  });
+
+  const results = generateResultsArray(currentBuildResults, prevBuildResults)
+  results.forEach(row => {
+    table.push([
+      chalk.white.bold(row[0]),
+      chalk.gray.bold(row[1]),
+      chalk.white.bold(row[2]),
+      percentChangeString(row[3]),
+      chalk.gray.bold(row[4]),
+      chalk.white.bold(row[5]),
+      percentChangeString(row[6]),
     ]);
   });
+
   return table.toString();
 }
 
 module.exports = {
+  currentBuildResults,
+  generateResultsArray,
   printResults,
   saveResults,
-  currentBuildResults,
+  resultsHeaders,
 };

scripts/tasks/danger.js

@@ -7,18 +7,18 @@
 
 'use strict';
 
-var path = require('path');
-var spawn = require('child_process').spawn;
+const path = require('path');
+const spawn = require('child_process').spawn;
 
-var extension = process.platform === 'win32' ? '.cmd' : '';
+const extension = process.platform === 'win32' ? '.cmd' : '';
 
-// This came from React Native's circle.yaml
+// This came from React Native's circle.yml
 const token = 'e622517d9f1136ea8900' + '07c6373666312cdfaa69';
 spawn(path.join('node_modules', '.bin', 'danger' + extension), [], {
   // Allow colors to pass through
   stdio: 'inherit',
   env: {
-    ...process.env, 
+    ...process.env,
     DANGER_GITHUB_API_TOKEN: token,
   },
 }).on('close', function(code) {