Skip to content

Commit

Permalink
Fork ReactDOMSharedInternals for www (#25791)
Browse files Browse the repository at this point in the history
This isn't the right way to do this, but internally we have some
restrictions so we need to add an indirection. Let's land this now so we
can catch up our sync and then fix forward from there.

Co-authored-by: Jan Kassens <jkassens@meta.com>
  • Loading branch information
poteto and kassens authored Dec 5, 2022
1 parent cd23e40 commit 2ccfa65
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 0 deletions.
16 changes: 16 additions & 0 deletions packages/shared/forks/ReactDOMSharedInternals.www.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
/**
* Copyright (c) Meta Platforms, Inc. and affiliates.
*
* This source code is licensed under the MIT license found in the
* LICENSE file in the root directory of this source tree.
*
* @flow
*/

// $FlowIgnore[cannot-resolve-module] provided by www
const ReactDOM = require('ReactDOMComet');

const ReactDOMSharedInternals =
ReactDOM.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED;

export default ReactDOMSharedInternals;
8 changes: 8 additions & 0 deletions scripts/rollup/forks.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,14 @@ const forks = Object.freeze({
if (entry === 'react-dom' || entry === 'react-dom/server-rendering-stub') {
return './packages/react-dom/src/ReactDOMSharedInternals.js';
}
switch (bundleType) {
case FB_WWW_DEV:
case FB_WWW_PROD:
case FB_WWW_PROFILING:
return './packages/shared/forks/ReactDOMSharedInternals.www.js';
default:
break;
}
if (
!entry.startsWith('react-dom/') &&
dependencies.indexOf('react-dom') === -1
Expand Down

0 comments on commit 2ccfa65

Please sign in to comment.