Extract getHookSourceLocationKey helper

This is used in environments that don't use "react".

Author: sebmarkbage

packages/react-devtools-shared/src/devtools/views/Components/InspectedElementHooksTree.js

@@ -20,7 +20,7 @@ import {getMetaValueLabel, serializeHooksForCopy} from '../utils';
 import Store from '../../store';
 import styles from './InspectedElementHooksTree.css';
 import {meta} from '../../../hydration';
-import {getHookSourceLocationKey} from 'react-devtools-shared/src/hookNamesCache';
+import {getHookSourceLocationKey} from 'react-devtools-shared/src/hookSourceLocation';
 import HookNamesModuleLoaderContext from 'react-devtools-shared/src/devtools/views/Components/HookNamesModuleLoaderContext';
 import isArray from 'react-devtools-shared/src/isArray';
 

packages/react-devtools-shared/src/devtools/views/Profiler/HookChangeSummary.js

@@ -21,10 +21,8 @@ import ButtonIcon from '../ButtonIcon';
 import {InspectedElementContext} from '../Components/InspectedElementContext';
 import {StoreContext} from '../context';
 
-import {
-  getAlreadyLoadedHookNames,
-  getHookSourceLocationKey,
-} from 'react-devtools-shared/src/hookNamesCache';
+import {getAlreadyLoadedHookNames} from 'react-devtools-shared/src/hookNamesCache';
+import {getHookSourceLocationKey} from 'react-devtools-shared/src/hookSourceLocation';
 import Toggle from '../Toggle';
 import type {HooksNode} from 'react-debug-tools/src/ReactDebugHooks';
 import type {ChangeDescription} from './types';

packages/react-devtools-shared/src/hookNamesCache.js

@@ -18,9 +18,7 @@ import type {
 import type {
   Element,
   HookNames,
-  HookSourceLocationKey,
 } from 'react-devtools-shared/src/frontend/types';
-import type {HookSource} from 'react-debug-tools/src/ReactDebugHooks';
 import type {FetchFileWithCaching} from 'react-devtools-shared/src/devtools/views/Components/FetchFileWithCachingContext';
 
 import * as React from 'react';
@@ -226,17 +224,6 @@ export function loadHookNames(
   return response;
 }
 
-export function getHookSourceLocationKey({
-  fileName,
-  lineNumber,
-  columnNumber,
-}: HookSource): HookSourceLocationKey {
-  if (fileName == null || lineNumber == null || columnNumber == null) {
-    throw Error('Hook source code location not found.');
-  }
-  return `${fileName}:${lineNumber}:${columnNumber}`;
-}
-
 export function clearHookNamesCache(): void {
   map = new WeakMap();
 }

packages/react-devtools-shared/src/hookSourceLocation.js

@@ -0,0 +1,22 @@
+/**
+ * Copyright (c) Meta Platforms, Inc. and affiliates.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ *
+ * @flow
+ */
+
+import type {HookSourceLocationKey} from 'react-devtools-shared/src/frontend/types';
+import type {HookSource} from 'react-debug-tools/src/ReactDebugHooks';
+
+export function getHookSourceLocationKey({
+  fileName,
+  lineNumber,
+  columnNumber,
+}: HookSource): HookSourceLocationKey {
+  if (fileName == null || lineNumber == null || columnNumber == null) {
+    throw Error('Hook source code location not found.');
+  }
+  return `${fileName}:${lineNumber}:${columnNumber}`;
+}

packages/react-devtools-shared/src/hooks/parseHookNames/index.js

@@ -12,6 +12,8 @@ import type {HooksNode, HooksTree} from 'react-debug-tools/src/ReactDebugHooks';
 import type {HookNames} from 'react-devtools-shared/src/frontend/types';
 import type {FetchFileWithCaching} from 'react-devtools-shared/src/devtools/views/Components/FetchFileWithCachingContext';
 
+import 'react';
+
 import {withAsyncPerfMeasurements} from 'react-devtools-shared/src/PerformanceLoggingUtils';
 import WorkerizedParseSourceAndMetadata from './parseSourceAndMetadata.worker';
 import typeof * as ParseSourceAndMetadataModule from './parseSourceAndMetadata';

packages/react-devtools-shared/src/hooks/parseHookNames/loadSourceAndMetadata.js

@@ -46,7 +46,7 @@
 //       and there is no need to convert runtime code to the original source.
 
 import {__DEBUG__} from 'react-devtools-shared/src/constants';
-import {getHookSourceLocationKey} from 'react-devtools-shared/src/hookNamesCache';
+import {getHookSourceLocationKey} from 'react-devtools-shared/src/hookSourceLocation';
 import {sourceMapIncludesSource} from '../SourceMapUtils';
 import {
   withAsyncPerfMeasurements,

packages/react-devtools-shared/src/hooks/parseHookNames/parseSourceAndMetadata.js

@@ -15,7 +15,7 @@ import LRU from 'lru-cache';
 import {getHookName} from '../astUtils';
 import {areSourceMapsAppliedToErrors} from '../ErrorTester';
 import {__DEBUG__} from 'react-devtools-shared/src/constants';
-import {getHookSourceLocationKey} from 'react-devtools-shared/src/hookNamesCache';
+import {getHookSourceLocationKey} from 'react-devtools-shared/src/hookSourceLocation';
 import {SourceMapMetadataConsumer} from '../SourceMapMetadataConsumer';
 import {
   withAsyncPerfMeasurements,