Change ReactVersion from CJS to ES module (#18181)

facebook · Feb 28, 2020 · 4469700 · 4469700
1 parent 58eedbb
commit 4469700
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 10 deletions.
diff --git a/packages/shared/ReactVersion.js b/packages/shared/ReactVersion.js
@@ -5,7 +5,5 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-'use strict';
-
 // TODO: this is special because it gets imported during build.
-module.exports = '16.13.0';
+export default '16.13.0';
diff --git a/scripts/release/publish-commands/update-stable-version-numbers.js b/scripts/release/publish-commands/update-stable-version-numbers.js
@@ -44,7 +44,7 @@ const run = async ({cwd, packages, skipPackages, tags}) => {
  const sourceReactVersion = readFileSync(
  sourceReactVersionPath,
  'utf8'
- ).replace(/module\.exports = '[^']+';/, `module.exports = '${version}';`);
+ ).replace(/export default '[^']+';/, `export default '${version}';`);
  writeFileSync(sourceReactVersionPath, sourceReactVersion);
  }
 };

diff --git a/scripts/release/utils.js b/scripts/release/utils.js
@@ -209,10 +209,7 @@ const updateVersionsForNext = async (cwd, reactVersion, version) => {
  const sourceReactVersion = readFileSync(
  sourceReactVersionPath,
  'utf8'
- ).replace(
- /module\.exports = '[^']+';/,
- `module.exports = '${reactVersion}';`
- );
+ ).replace(/export default '[^']+';/, `export default '${reactVersion}';`);
  writeFileSync(sourceReactVersionPath, sourceReactVersion);
 
  // Update the root package.json.

diff --git a/scripts/tasks/version-check.js b/scripts/tasks/version-check.js
@@ -7,15 +7,20 @@
 
 'use strict';
 
-const reactVersion = require('../../package.json').version;
+const fs = require('fs');
+const ReactVersionSrc = fs.readFileSync(
+ require.resolve('../../packages/shared/ReactVersion')
+);
+const reactVersion = /export default '([^']+)';/.exec(ReactVersionSrc)[1];
+
 const versions = {
  'packages/react/package.json': require('../../packages/react/package.json')
  .version,
  'packages/react-dom/package.json': require('../../packages/react-dom/package.json')
  .version,
  'packages/react-test-renderer/package.json': require('../../packages/react-test-renderer/package.json')
  .version,
- 'packages/shared/ReactVersion.js': require('../../packages/shared/ReactVersion'),
+ 'packages/shared/ReactVersion.js': reactVersion,
 };
 
 let allVersionsMatch = true;