Integrate review feedback

unstubbable · unstubbable · commit 458ad5bbf11c · 2025-08-27T09:43:14.000+02:00
diff --git a/packages/react-client/src/ReactFlightClient.js b/packages/react-client/src/ReactFlightClient.js
@@ -341,10 +341,10 @@ export type FindSourceMapURLCallback = (
 
 export type DebugChannelCallback = (message: string) => void;
 
-export interface DebugChannel {
-  hasReadable: boolean;
-  callback?: DebugChannelCallback;
-}
+export type DebugChannel = {
+  hasReadable: boolean,
+  callback: DebugChannelCallback | null,
+};
 
 type Response = {
   _bundlerConfig: ServerConsumerModuleMap,
@@ -410,7 +410,7 @@ function getWeakResponse(response: Response): WeakResponse {
 }
 
 function closeDebugChannel(debugChannel: DebugChannel): void {
-  if (debugChannel.callback !== undefined) {
+  if (debugChannel.callback) {
     debugChannel.callback('');
   }
 }
diff --git a/packages/react-server-dom-esm/src/client/ReactFlightDOMClientBrowser.js b/packages/react-server-dom-esm/src/client/ReactFlightDOMClientBrowser.js
@@ -82,7 +82,7 @@ function createResponseFromOptions(options: void | Options) {
               ? createDebugCallbackFromWritableStream(
                   options.debugChannel.writable,
                 )
-              : undefined,
+              : null,
         }
       : undefined;
 
diff --git a/packages/react-server-dom-esm/src/client/ReactFlightDOMClientNode.js b/packages/react-server-dom-esm/src/client/ReactFlightDOMClientNode.js
@@ -91,7 +91,10 @@ function createFromNodeStream<T>(
 ): Thenable<T> {
   const debugChannel: void | DebugChannel =
     __DEV__ && options && options.debugChannel !== undefined
-      ? {hasReadable: options.debugChannel.readable !== undefined}
+      ? {
+          hasReadable: options.debugChannel.readable !== undefined,
+          callback: null,
+        }
       : undefined;
 
   const response: Response = createResponse(
diff --git a/packages/react-server-dom-parcel/src/client/ReactFlightDOMClientBrowser.js b/packages/react-server-dom-parcel/src/client/ReactFlightDOMClientBrowser.js
@@ -110,7 +110,7 @@ function createResponseFromOptions(options: void | Options) {
               ? createDebugCallbackFromWritableStream(
                   options.debugChannel.writable,
                 )
-              : undefined,
+              : null,
         }
       : undefined;
 
diff --git a/packages/react-server-dom-parcel/src/client/ReactFlightDOMClientEdge.js b/packages/react-server-dom-parcel/src/client/ReactFlightDOMClientEdge.js
@@ -86,7 +86,10 @@ export type Options = {
 function createResponseFromOptions(options?: Options) {
   const debugChannel: void | DebugChannel =
     __DEV__ && options && options.debugChannel !== undefined
-      ? {hasReadable: options.debugChannel.readable !== undefined}
+      ? {
+          hasReadable: options.debugChannel.readable !== undefined,
+          callback: null,
+        }
       : undefined;
 
   return createResponse(
diff --git a/packages/react-server-dom-parcel/src/client/ReactFlightDOMClientNode.js b/packages/react-server-dom-parcel/src/client/ReactFlightDOMClientNode.js
@@ -84,7 +84,10 @@ export function createFromNodeStream<T>(
 ): Thenable<T> {
   const debugChannel: void | DebugChannel =
     __DEV__ && options && options.debugChannel !== undefined
-      ? {hasReadable: options.debugChannel.readable !== undefined}
+      ? {
+          hasReadable: options.debugChannel.readable !== undefined,
+          callback: null,
+        }
       : undefined;
 
   const response: Response = createResponse(
diff --git a/packages/react-server-dom-turbopack/src/client/ReactFlightDOMClientBrowser.js b/packages/react-server-dom-turbopack/src/client/ReactFlightDOMClientBrowser.js
@@ -81,7 +81,7 @@ function createResponseFromOptions(options: void | Options) {
               ? createDebugCallbackFromWritableStream(
                   options.debugChannel.writable,
                 )
-              : undefined,
+              : null,
         }
       : undefined;
 
diff --git a/packages/react-server-dom-turbopack/src/client/ReactFlightDOMClientEdge.js b/packages/react-server-dom-turbopack/src/client/ReactFlightDOMClientEdge.js
@@ -86,7 +86,10 @@ export type Options = {
 function createResponseFromOptions(options: Options) {
   const debugChannel: void | DebugChannel =
     __DEV__ && options && options.debugChannel !== undefined
-      ? {hasReadable: options.debugChannel.readable !== undefined}
+      ? {
+          hasReadable: options.debugChannel.readable !== undefined,
+          callback: null,
+        }
       : undefined;
 
   return createResponse(
diff --git a/packages/react-server-dom-turbopack/src/client/ReactFlightDOMClientNode.js b/packages/react-server-dom-turbopack/src/client/ReactFlightDOMClientNode.js
@@ -93,7 +93,10 @@ function createFromNodeStream<T>(
 ): Thenable<T> {
   const debugChannel: void | DebugChannel =
     __DEV__ && options && options.debugChannel !== undefined
-      ? {hasReadable: options.debugChannel.readable !== undefined}
+      ? {
+          hasReadable: options.debugChannel.readable !== undefined,
+          callback: null,
+        }
       : undefined;
 
   const response: Response = createResponse(
diff --git a/packages/react-server-dom-webpack/src/client/ReactFlightDOMClientBrowser.js b/packages/react-server-dom-webpack/src/client/ReactFlightDOMClientBrowser.js
@@ -81,7 +81,7 @@ function createResponseFromOptions(options: void | Options) {
               ? createDebugCallbackFromWritableStream(
                   options.debugChannel.writable,
                 )
-              : undefined,
+              : null,
         }
       : undefined;
 
diff --git a/packages/react-server-dom-webpack/src/client/ReactFlightDOMClientEdge.js b/packages/react-server-dom-webpack/src/client/ReactFlightDOMClientEdge.js
@@ -86,7 +86,10 @@ export type Options = {
 function createResponseFromOptions(options: Options) {
   const debugChannel: void | DebugChannel =
     __DEV__ && options && options.debugChannel !== undefined
-      ? {hasReadable: options.debugChannel.readable !== undefined}
+      ? {
+          hasReadable: options.debugChannel.readable !== undefined,
+          callback: null,
+        }
       : undefined;
 
   return createResponse(
diff --git a/packages/react-server-dom-webpack/src/client/ReactFlightDOMClientNode.js b/packages/react-server-dom-webpack/src/client/ReactFlightDOMClientNode.js
@@ -93,7 +93,10 @@ function createFromNodeStream<T>(
 ): Thenable<T> {
   const debugChannel: void | DebugChannel =
     __DEV__ && options && options.debugChannel !== undefined
-      ? {hasReadable: options.debugChannel.readable !== undefined}
+      ? {
+          hasReadable: options.debugChannel.readable !== undefined,
+          callback: null,
+        }
       : undefined;
 
   const response: Response = createResponse(

Original file line number	Diff line number	Diff line change
`@@ -341,10 +341,10 @@ export type FindSourceMapURLCallback = (`
`341`	`341`
`342`	`342`	`export type DebugChannelCallback = (message: string) => void;`
`343`	`343`
`344`		`-export interface DebugChannel {`
`345`		`- hasReadable: boolean;`
`346`		`- callback?: DebugChannelCallback;`
`347`		`-}`
	`344`	`+export type DebugChannel = {`
	`345`	`+ hasReadable: boolean,`
	`346`	`+ callback: DebugChannelCallback \| null,`
	`347`	`+};`
`348`	`348`
`349`	`349`	`type Response = {`
`350`	`350`	`_bundlerConfig: ServerConsumerModuleMap,`
`@@ -410,7 +410,7 @@ function getWeakResponse(response: Response): WeakResponse {`
`410`	`410`	`}`
`411`	`411`
`412`	`412`	`function closeDebugChannel(debugChannel: DebugChannel): void {`
`413`		`- if (debugChannel.callback !== undefined) {`
	`413`	`+ if (debugChannel.callback) {`
`414`	`414`	`debugChannel.callback('');`
`415`	`415`	`}`
`416`	`416`	`}`
Original file line number	Diff line number	Diff line change
`@@ -82,7 +82,7 @@ function createResponseFromOptions(options: void \| Options) {`
`82`	`82`	`? createDebugCallbackFromWritableStream(`
`83`	`83`	`options.debugChannel.writable,`
`84`	`84`	`)`
`85`		`- : undefined,`
	`85`	`+ : null,`
`86`	`86`	`}`
`87`	`87`	`: undefined;`
`88`	`88`
Original file line number	Diff line number	Diff line change
`@@ -110,7 +110,7 @@ function createResponseFromOptions(options: void \| Options) {`
`110`	`110`	`? createDebugCallbackFromWritableStream(`
`111`	`111`	`options.debugChannel.writable,`
`112`	`112`	`)`
`113`		`- : undefined,`
	`113`	`+ : null,`
`114`	`114`	`}`
`115`	`115`	`: undefined;`
`116`	`116`
Original file line number	Diff line number	Diff line change
`@@ -81,7 +81,7 @@ function createResponseFromOptions(options: void \| Options) {`
`81`	`81`	`? createDebugCallbackFromWritableStream(`
`82`	`82`	`options.debugChannel.writable,`
`83`	`83`	`)`
`84`		`- : undefined,`
	`84`	`+ : null,`
`85`	`85`	`}`
`86`	`86`	`: undefined;`
`87`	`87`