Skip to content

Commit 54c0edc

Browse files
authored
[ci] Don't use branch name for concurrency (#31296)
I happened to notice some jobs on main get canceled if another PR landed before the prior commit on main had finished running CI. This is not great for difftrain because the commit artifacts job relies on the CI jobs on main finishing before it triggers. This would lead to commits being skipped on DiffTrain which is not great for provenance since we want it to be a 1:1 sync. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/31296). * #31297 * __->__ #31296
1 parent 9deb367 commit 54c0edc

File tree

5 files changed

+5
-5
lines changed

5 files changed

+5
-5
lines changed

.github/workflows/compiler_playground.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ on:
99
- .github/workflows/compiler-playground.yml
1010

1111
concurrency:
12-
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref || github.run_id }}
12+
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
1313
cancel-in-progress: true
1414

1515
env:

.github/workflows/compiler_rust.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ on:
1616
- compiler/*.toml
1717

1818
concurrency:
19-
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref || github.run_id }}
19+
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
2020
cancel-in-progress: true
2121

2222
env:

.github/workflows/compiler_typescript.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ on:
99
- .github/workflows/compiler_typescript.yml
1010

1111
concurrency:
12-
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref || github.run_id }}
12+
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
1313
cancel-in-progress: true
1414

1515
env:

.github/workflows/runtime_build_and_test.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ on:
88
- compiler/**
99

1010
concurrency:
11-
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref || github.run_id }}
11+
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
1212
cancel-in-progress: true
1313

1414
env:

.github/workflows/shared_lint.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ on:
66
pull_request:
77

88
concurrency:
9-
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref || github.run_id }}
9+
group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.run_id }}
1010
cancel-in-progress: true
1111

1212
env:

0 commit comments

Comments
 (0)