Skip to content

Commit 5747cad

Browse files
authored
[DevTools] Don't hide overflow rectangles (#34852)
I get the wish to click the shadow but not all child boundaries are within the bounds of the outer Suspense boundary's node. Sometimes they overflow naturally and if we make it overflow hidden we hide the boundaries. Maybe it would be ok if they're actually clipped by the real DOM but right now it covers up boundaries that should be there. Additionally, there's also a common case where the parent boundary shrinks when suspending the children. That then causes the suspended child boundaries to be clipped so that you can't restore them. Maybe the virtual boundary shouldn't shrink in this case.
1 parent 751edd6 commit 5747cad

File tree

1 file changed

+0
-5
lines changed

1 file changed

+0
-5
lines changed

packages/react-devtools-shared/src/devtools/views/SuspenseTab/SuspenseRects.css

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -19,11 +19,6 @@
1919

2020
.SuspenseRectsBoundaryChildren {
2121
pointer-events: none;
22-
/**
23-
* So that the shadow of Boundaries within is clipped off.
24-
* Otherwise it would look like this boundary is further elevated.
25-
*/
26-
overflow: hidden;
2722
}
2823

2924
.SuspenseRectsScaledRect[data-visible='false'] > .SuspenseRectsBoundaryChildren {

0 commit comments

Comments
 (0)