Skip to content

Commit 5959f7d

Browse files
committed
Fix Failed to execute 'measure' on 'Performance' error (#32823)
When `startTime` still has its initial value of `-1.1` we must not call `logComponentMount`. This can occur when rendering a `'next/dynamic'` component with `{ssr: false}` in a client component, for example. Unfortunately, I didn't manage to reproduce this scenario in a unit test. DiffTrain build for [3366146](3366146)
1 parent e4590b3 commit 5959f7d

34 files changed

+126
-106
lines changed

compiled/facebook-www/REVISION

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
365c031fd2354e94248ed9390f13fe2975b994f6
1+
336614679600af371b06371c0fbdd31fd9838231
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
365c031fd2354e94248ed9390f13fe2975b994f6
1+
336614679600af371b06371c0fbdd31fd9838231

compiled/facebook-www/React-dev.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1538,7 +1538,7 @@ __DEV__ &&
15381538
exports.useTransition = function () {
15391539
return resolveDispatcher().useTransition();
15401540
};
1541-
exports.version = "19.2.0-www-classic-365c031f-20250407";
1541+
exports.version = "19.2.0-www-classic-33661467-20250407";
15421542
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
15431543
"function" ===
15441544
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-dev.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1538,7 +1538,7 @@ __DEV__ &&
15381538
exports.useTransition = function () {
15391539
return resolveDispatcher().useTransition();
15401540
};
1541-
exports.version = "19.2.0-www-modern-365c031f-20250407";
1541+
exports.version = "19.2.0-www-modern-33661467-20250407";
15421542
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
15431543
"function" ===
15441544
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-prod.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -636,4 +636,4 @@ exports.useSyncExternalStore = function (
636636
exports.useTransition = function () {
637637
return ReactSharedInternals.H.useTransition();
638638
};
639-
exports.version = "19.2.0-www-classic-365c031f-20250407";
639+
exports.version = "19.2.0-www-classic-33661467-20250407";

compiled/facebook-www/React-prod.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -636,4 +636,4 @@ exports.useSyncExternalStore = function (
636636
exports.useTransition = function () {
637637
return ReactSharedInternals.H.useTransition();
638638
};
639-
exports.version = "19.2.0-www-modern-365c031f-20250407";
639+
exports.version = "19.2.0-www-modern-33661467-20250407";

compiled/facebook-www/React-profiling.classic.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -640,7 +640,7 @@ exports.useSyncExternalStore = function (
640640
exports.useTransition = function () {
641641
return ReactSharedInternals.H.useTransition();
642642
};
643-
exports.version = "19.2.0-www-classic-365c031f-20250407";
643+
exports.version = "19.2.0-www-classic-33661467-20250407";
644644
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
645645
"function" ===
646646
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/React-profiling.modern.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -640,7 +640,7 @@ exports.useSyncExternalStore = function (
640640
exports.useTransition = function () {
641641
return ReactSharedInternals.H.useTransition();
642642
};
643-
exports.version = "19.2.0-www-modern-365c031f-20250407";
643+
exports.version = "19.2.0-www-modern-33661467-20250407";
644644
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
645645
"function" ===
646646
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.classic.js

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12650,7 +12650,8 @@ __DEV__ &&
1265012650
0 !== (finishedWork.mode & 2) &&
1265112651
!inHydratedSubtree &&
1265212652
((finishedRoot = finishedWork.actualStartTime),
12653-
0.05 < endTime - finishedRoot &&
12653+
0 <= finishedRoot &&
12654+
0.05 < endTime - finishedRoot &&
1265412655
logComponentReappeared(
1265512656
finishedWork,
1265612657
finishedRoot,
@@ -12724,7 +12725,8 @@ __DEV__ &&
1272412725
null !== finishedWork.return.alternate)
1272512726
)
1272612727
(committedLanes = finishedWork.actualStartTime),
12727-
0.05 < endTime - committedLanes &&
12728+
0 <= committedLanes &&
12729+
0.05 < endTime - committedLanes &&
1272812730
logComponentTrigger(
1272912731
finishedWork,
1273012732
committedLanes,
@@ -18524,10 +18526,10 @@ __DEV__ &&
1852418526
(function () {
1852518527
var internals = {
1852618528
bundleType: 1,
18527-
version: "19.2.0-www-classic-365c031f-20250407",
18529+
version: "19.2.0-www-classic-33661467-20250407",
1852818530
rendererPackageName: "react-art",
1852918531
currentDispatcherRef: ReactSharedInternals,
18530-
reconcilerVersion: "19.2.0-www-classic-365c031f-20250407"
18532+
reconcilerVersion: "19.2.0-www-classic-33661467-20250407"
1853118533
};
1853218534
internals.overrideHookState = overrideHookState;
1853318535
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -18561,7 +18563,7 @@ __DEV__ &&
1856118563
exports.Shape = Shape;
1856218564
exports.Surface = Surface;
1856318565
exports.Text = Text;
18564-
exports.version = "19.2.0-www-classic-365c031f-20250407";
18566+
exports.version = "19.2.0-www-classic-33661467-20250407";
1856518567
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1856618568
"function" ===
1856718569
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

compiled/facebook-www/ReactART-dev.modern.js

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12468,7 +12468,8 @@ __DEV__ &&
1246812468
0 !== (finishedWork.mode & 2) &&
1246912469
!inHydratedSubtree &&
1247012470
((finishedRoot = finishedWork.actualStartTime),
12471-
0.05 < endTime - finishedRoot &&
12471+
0 <= finishedRoot &&
12472+
0.05 < endTime - finishedRoot &&
1247212473
logComponentReappeared(
1247312474
finishedWork,
1247412475
finishedRoot,
@@ -12542,7 +12543,8 @@ __DEV__ &&
1254212543
null !== finishedWork.return.alternate)
1254312544
)
1254412545
(committedLanes = finishedWork.actualStartTime),
12545-
0.05 < endTime - committedLanes &&
12546+
0 <= committedLanes &&
12547+
0.05 < endTime - committedLanes &&
1254612548
logComponentTrigger(
1254712549
finishedWork,
1254812550
committedLanes,
@@ -18296,10 +18298,10 @@ __DEV__ &&
1829618298
(function () {
1829718299
var internals = {
1829818300
bundleType: 1,
18299-
version: "19.2.0-www-modern-365c031f-20250407",
18301+
version: "19.2.0-www-modern-33661467-20250407",
1830018302
rendererPackageName: "react-art",
1830118303
currentDispatcherRef: ReactSharedInternals,
18302-
reconcilerVersion: "19.2.0-www-modern-365c031f-20250407"
18304+
reconcilerVersion: "19.2.0-www-modern-33661467-20250407"
1830318305
};
1830418306
internals.overrideHookState = overrideHookState;
1830518307
internals.overrideHookStateDeletePath = overrideHookStateDeletePath;
@@ -18333,7 +18335,7 @@ __DEV__ &&
1833318335
exports.Shape = Shape;
1833418336
exports.Surface = Surface;
1833518337
exports.Text = Text;
18336-
exports.version = "19.2.0-www-modern-365c031f-20250407";
18338+
exports.version = "19.2.0-www-modern-33661467-20250407";
1833718339
"undefined" !== typeof __REACT_DEVTOOLS_GLOBAL_HOOK__ &&
1833818340
"function" ===
1833918341
typeof __REACT_DEVTOOLS_GLOBAL_HOOK__.registerInternalModuleStop &&

0 commit comments

Comments
 (0)