Small cleanup in ReactFiberCompleteWork (#27681)

kassens · kassens · commit 6bab074fd2eb · 2023-11-10T15:25:47.000Z
These are all functionally equivalent changes. - remove double negation and more explicit naming of `hadNoMutationsEffects` - use docblock syntax that's consumed by Flow - remove useless cast DiffTrain build for [c4c87e0](c4c87e0)
diff --git a/compiled/facebook-www/REVISION b/compiled/facebook-www/REVISION
@@ -1 +1 @@
-0e352ea01c0209b6c5e23f0e857af4e01c783024
+c4c87e049b891ebc38a7a14b8c93285c877e90af
diff --git a/compiled/facebook-www/React-prod.classic.js b/compiled/facebook-www/React-prod.classic.js
@@ -587,4 +587,4 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactCurrentDispatcher.current.useTransition();
 };
-exports.version = "18.3.0-www-classic-93c0536e";
+exports.version = "18.3.0-www-classic-b6e8ec88";
diff --git a/compiled/facebook-www/React-prod.modern.js b/compiled/facebook-www/React-prod.modern.js
@@ -579,4 +579,4 @@ exports.useSyncExternalStore = function (
 exports.useTransition = function () {
   return ReactCurrentDispatcher.current.useTransition();
 };
-exports.version = "18.3.0-www-modern-bd02fc79";
+exports.version = "18.3.0-www-modern-7fb93a7a";
diff --git a/compiled/facebook-www/ReactART-dev.classic.js b/compiled/facebook-www/ReactART-dev.classic.js
@@ -66,7 +66,7 @@ if (__DEV__) {
       return self;
     }
 
-    var ReactVersion = "18.3.0-www-classic-6755280f";
+    var ReactVersion = "18.3.0-www-classic-845b4481";
 
     var LegacyRoot = 0;
     var ConcurrentRoot = 1;
@@ -18667,9 +18667,12 @@ if (__DEV__) {
       };
     }
 
+    /**
+     * Tag the fiber with an update effect. This turns a Placement into
+     * a PlacementAndUpdate.
+     */
+
     function markUpdate(workInProgress) {
-      // Tag the fiber with an update effect. This turns a Placement into
-      // a PlacementAndUpdate.
       workInProgress.flags |= Update;
     }
 
diff --git a/compiled/facebook-www/ReactART-dev.modern.js b/compiled/facebook-www/ReactART-dev.modern.js
@@ -66,7 +66,7 @@ if (__DEV__) {
       return self;
     }
 
-    var ReactVersion = "18.3.0-www-modern-adf7c13c";
+    var ReactVersion = "18.3.0-www-modern-b4d8ae24";
 
     var LegacyRoot = 0;
     var ConcurrentRoot = 1;
@@ -18340,9 +18340,12 @@ if (__DEV__) {
       };
     }
 
+    /**
+     * Tag the fiber with an update effect. This turns a Placement into
+     * a PlacementAndUpdate.
+     */
+
     function markUpdate(workInProgress) {
-      // Tag the fiber with an update effect. This turns a Placement into
-      // a PlacementAndUpdate.
       workInProgress.flags |= Update;
     }
 
diff --git a/compiled/facebook-www/ReactDOM-dev.classic.js b/compiled/facebook-www/ReactDOM-dev.classic.js
@@ -23663,9 +23663,12 @@ if (__DEV__) {
       };
     }
 
+    /**
+     * Tag the fiber with an update effect. This turns a Placement into
+     * a PlacementAndUpdate.
+     */
+
     function markUpdate(workInProgress) {
-      // Tag the fiber with an update effect. This turns a Placement into
-      // a PlacementAndUpdate.
       workInProgress.flags |= Update;
     }
 
@@ -34881,7 +34884,7 @@ if (__DEV__) {
       return root;
     }
 
-    var ReactVersion = "18.3.0-www-classic-a5cdf515";
+    var ReactVersion = "18.3.0-www-classic-d456dfab";
 
     function createPortal$1(
       children,
diff --git a/compiled/facebook-www/ReactDOM-dev.modern.js b/compiled/facebook-www/ReactDOM-dev.modern.js
@@ -23522,9 +23522,12 @@ if (__DEV__) {
       };
     }
 
+    /**
+     * Tag the fiber with an update effect. This turns a Placement into
+     * a PlacementAndUpdate.
+     */
+
     function markUpdate(workInProgress) {
-      // Tag the fiber with an update effect. This turns a Placement into
-      // a PlacementAndUpdate.
       workInProgress.flags |= Update;
     }
 
@@ -34702,7 +34705,7 @@ if (__DEV__) {
       return root;
     }
 
-    var ReactVersion = "18.3.0-www-modern-b881b4d4";
+    var ReactVersion = "18.3.0-www-modern-81cc9bc4";
 
     function createPortal$1(
       children,
diff --git a/compiled/facebook-www/ReactDOMServer-dev.modern.js b/compiled/facebook-www/ReactDOMServer-dev.modern.js
@@ -19,7 +19,7 @@ if (__DEV__) {
     var React = require("react");
     var ReactDOM = require("react-dom");
 
-    var ReactVersion = "18.3.0-www-modern-adf7c13c";
+    var ReactVersion = "18.3.0-www-modern-b4d8ae24";
 
     // This refers to a WWW module.
     var warningWWW = require("warning");
diff --git a/compiled/facebook-www/ReactDOMTesting-dev.classic.js b/compiled/facebook-www/ReactDOMTesting-dev.classic.js
@@ -23800,9 +23800,12 @@ if (__DEV__) {
       };
     }
 
+    /**
+     * Tag the fiber with an update effect. This turns a Placement into
+     * a PlacementAndUpdate.
+     */
+
     function markUpdate(workInProgress) {
-      // Tag the fiber with an update effect. This turns a Placement into
-      // a PlacementAndUpdate.
       workInProgress.flags |= Update;
     }
 
@@ -35505,7 +35508,7 @@ if (__DEV__) {
       return root;
     }
 
-    var ReactVersion = "18.3.0-www-classic-488f91a4";
+    var ReactVersion = "18.3.0-www-classic-adaf3ac3";
 
     function createPortal$1(
       children,
diff --git a/compiled/facebook-www/ReactDOMTesting-dev.modern.js b/compiled/facebook-www/ReactDOMTesting-dev.modern.js
@@ -23659,9 +23659,12 @@ if (__DEV__) {
       };
     }
 
+    /**
+     * Tag the fiber with an update effect. This turns a Placement into
+     * a PlacementAndUpdate.
+     */
+
     function markUpdate(workInProgress) {
-      // Tag the fiber with an update effect. This turns a Placement into
-      // a PlacementAndUpdate.
       workInProgress.flags |= Update;
     }
 
@@ -35326,7 +35329,7 @@ if (__DEV__) {
       return root;
     }
 
-    var ReactVersion = "18.3.0-www-modern-bd02fc79";
+    var ReactVersion = "18.3.0-www-modern-7fb93a7a";
 
     function createPortal$1(
       children,
diff --git a/compiled/facebook-www/ReactTestRenderer-dev.classic.js b/compiled/facebook-www/ReactTestRenderer-dev.classic.js
@@ -16702,9 +16702,12 @@ if (__DEV__) {
       };
     }
 
+    /**
+     * Tag the fiber with an update effect. This turns a Placement into
+     * a PlacementAndUpdate.
+     */
+
     function markUpdate(workInProgress) {
-      // Tag the fiber with an update effect. This turns a Placement into
-      // a PlacementAndUpdate.
       workInProgress.flags |= Update;
     }
 
@@ -25810,7 +25813,7 @@ if (__DEV__) {
       return root;
     }
 
-    var ReactVersion = "18.3.0-www-classic-93c0536e";
+    var ReactVersion = "18.3.0-www-classic-b6e8ec88";
 
     // Might add PROFILE later.
 
diff --git a/compiled/facebook-www/ReactTestRenderer-dev.modern.js b/compiled/facebook-www/ReactTestRenderer-dev.modern.js
@@ -16702,9 +16702,12 @@ if (__DEV__) {
       };
     }
 
+    /**
+     * Tag the fiber with an update effect. This turns a Placement into
+     * a PlacementAndUpdate.
+     */
+
     function markUpdate(workInProgress) {
-      // Tag the fiber with an update effect. This turns a Placement into
-      // a PlacementAndUpdate.
       workInProgress.flags |= Update;
     }
 
@@ -25810,7 +25813,7 @@ if (__DEV__) {
       return root;
     }
 
-    var ReactVersion = "18.3.0-www-modern-b9808d6c";
+    var ReactVersion = "18.3.0-www-modern-73e7dcee";
 
     // Might add PROFILE later.
 

Original file line number	Diff line number	Diff line change
`@@ -1 +1 @@`
`1`		`-0e352ea01c0209b6c5e23f0e857af4e01c783024`
	`1`	`+c4c87e049b891ebc38a7a14b8c93285c877e90af`
Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ if (__DEV__) {`
`66`	`66`	`return self;`
`67`	`67`	`}`
`68`	`68`
`69`		`- var ReactVersion = "18.3.0-www-classic-6755280f";`
	`69`	`+ var ReactVersion = "18.3.0-www-classic-845b4481";`
`70`	`70`
`71`	`71`	`var LegacyRoot = 0;`
`72`	`72`	`var ConcurrentRoot = 1;`
`@@ -18667,9 +18667,12 @@ if (__DEV__) {`
`18667`	`18667`	`};`
`18668`	`18668`	`}`
`18669`	`18669`
	`18670`	`+ /**`
	`18671`	`+ * Tag the fiber with an update effect. This turns a Placement into`
	`18672`	`+ * a PlacementAndUpdate.`
	`18673`	`+ */`
	`18674`	`+`
`18670`	`18675`	`function markUpdate(workInProgress) {`
`18671`		`- // Tag the fiber with an update effect. This turns a Placement into`
`18672`		`- // a PlacementAndUpdate.`
`18673`	`18676`	`workInProgress.flags \|= Update;`
`18674`	`18677`	`}`
`18675`	`18678`
Original file line number	Diff line number	Diff line change
`@@ -23663,9 +23663,12 @@ if (__DEV__) {`
`23663`	`23663`	`};`
`23664`	`23664`	`}`
`23665`	`23665`
	`23666`	`+ /**`
	`23667`	`+ * Tag the fiber with an update effect. This turns a Placement into`
	`23668`	`+ * a PlacementAndUpdate.`
	`23669`	`+ */`
	`23670`	`+`
`23666`	`23671`	`function markUpdate(workInProgress) {`
`23667`		`- // Tag the fiber with an update effect. This turns a Placement into`
`23668`		`- // a PlacementAndUpdate.`
`23669`	`23672`	`workInProgress.flags \|= Update;`
`23670`	`23673`	`}`
`23671`	`23674`
`@@ -34881,7 +34884,7 @@ if (__DEV__) {`
`34881`	`34884`	`return root;`
`34882`	`34885`	`}`
`34883`	`34886`
`34884`		`- var ReactVersion = "18.3.0-www-classic-a5cdf515";`
	`34887`	`+ var ReactVersion = "18.3.0-www-classic-d456dfab";`
`34885`	`34888`
`34886`	`34889`	`function createPortal$1(`
`34887`	`34890`	`children,`
Original file line number	Diff line number	Diff line change
`@@ -23522,9 +23522,12 @@ if (__DEV__) {`
`23522`	`23522`	`};`
`23523`	`23523`	`}`
`23524`	`23524`
	`23525`	`+ /**`
	`23526`	`+ * Tag the fiber with an update effect. This turns a Placement into`
	`23527`	`+ * a PlacementAndUpdate.`
	`23528`	`+ */`
	`23529`	`+`
`23525`	`23530`	`function markUpdate(workInProgress) {`
`23526`		`- // Tag the fiber with an update effect. This turns a Placement into`
`23527`		`- // a PlacementAndUpdate.`
`23528`	`23531`	`workInProgress.flags \|= Update;`
`23529`	`23532`	`}`
`23530`	`23533`
`@@ -34702,7 +34705,7 @@ if (__DEV__) {`
`34702`	`34705`	`return root;`
`34703`	`34706`	`}`
`34704`	`34707`
`34705`		`- var ReactVersion = "18.3.0-www-modern-b881b4d4";`
	`34708`	`+ var ReactVersion = "18.3.0-www-modern-81cc9bc4";`
`34706`	`34709`
`34707`	`34710`	`function createPortal$1(`
`34708`	`34711`	`children,`
Original file line number	Diff line number	Diff line change
`@@ -23800,9 +23800,12 @@ if (__DEV__) {`
`23800`	`23800`	`};`
`23801`	`23801`	`}`
`23802`	`23802`
	`23803`	`+ /**`
	`23804`	`+ * Tag the fiber with an update effect. This turns a Placement into`
	`23805`	`+ * a PlacementAndUpdate.`
	`23806`	`+ */`
	`23807`	`+`
`23803`	`23808`	`function markUpdate(workInProgress) {`
`23804`		`- // Tag the fiber with an update effect. This turns a Placement into`
`23805`		`- // a PlacementAndUpdate.`
`23806`	`23809`	`workInProgress.flags \|= Update;`
`23807`	`23810`	`}`
`23808`	`23811`
`@@ -35505,7 +35508,7 @@ if (__DEV__) {`
`35505`	`35508`	`return root;`
`35506`	`35509`	`}`
`35507`	`35510`
`35508`		`- var ReactVersion = "18.3.0-www-classic-488f91a4";`
	`35511`	`+ var ReactVersion = "18.3.0-www-classic-adaf3ac3";`
`35509`	`35512`
`35510`	`35513`	`function createPortal$1(`
`35511`	`35514`	`children,`
Original file line number	Diff line number	Diff line change
`@@ -23659,9 +23659,12 @@ if (__DEV__) {`
`23659`	`23659`	`};`
`23660`	`23660`	`}`
`23661`	`23661`
	`23662`	`+ /**`
	`23663`	`+ * Tag the fiber with an update effect. This turns a Placement into`
	`23664`	`+ * a PlacementAndUpdate.`
	`23665`	`+ */`
	`23666`	`+`
`23662`	`23667`	`function markUpdate(workInProgress) {`
`23663`		`- // Tag the fiber with an update effect. This turns a Placement into`
`23664`		`- // a PlacementAndUpdate.`
`23665`	`23668`	`workInProgress.flags \|= Update;`
`23666`	`23669`	`}`
`23667`	`23670`
`@@ -35326,7 +35329,7 @@ if (__DEV__) {`
`35326`	`35329`	`return root;`
`35327`	`35330`	`}`
`35328`	`35331`
`35329`		`- var ReactVersion = "18.3.0-www-modern-bd02fc79";`
	`35332`	`+ var ReactVersion = "18.3.0-www-modern-7fb93a7a";`
`35330`	`35333`
`35331`	`35334`	`function createPortal$1(`
`35332`	`35335`	`children,`