Skip to content

Commit 84aa038

Browse files
kassenskassens
committed
[cleanup] remove unused values from ReactFeatureFlags.www-dynamic (#25575)
These values are never imported into `ReactFeatureFlags.www.js`, so they're unused: - `allowConcurrentByDefault` - `consoleManagedByDevToolsDuringStrictMode` These values are never set in the WWW module (https://fburl.com/code/dsb2ohv8), so they're always `undefined` on www: - `createRootStrictEffectsByDefault` - `enableClientRenderFallbackOnTextMismatch` DiffTrain build for [7002a67](7002a67) [View git log for this commit](https://github.com/facebook/react/commits/7002a6743ebb24ed55af8f626c89dd39460230fc)
1 parent 198e9a4 commit 84aa038

37 files changed

+192
-334
lines changed

‎compiled/facebook-www/JSXDEVRuntime-dev.classic.js‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,6 @@ var disableInputAttributeSyncing =
121121
dynamicFeatureFlags.deferRenderPhaseUpdateToNextBatch,
122122
enableDebugTracing = dynamicFeatureFlags.enableDebugTracing,
123123
skipUnmountedBoundaries = dynamicFeatureFlags.skipUnmountedBoundaries,
124-
createRootStrictEffectsByDefault =
125-
dynamicFeatureFlags.createRootStrictEffectsByDefault,
126124
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
127125
disableNativeComponentFrames =
128126
dynamicFeatureFlags.disableNativeComponentFrames,
@@ -134,8 +132,6 @@ var disableInputAttributeSyncing =
134132
enableUnifiedSyncLane = dynamicFeatureFlags.enableUnifiedSyncLane,
135133
enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay =
136134
dynamicFeatureFlags.enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay,
137-
enableClientRenderFallbackOnTextMismatch =
138-
dynamicFeatureFlags.enableClientRenderFallbackOnTextMismatch,
139135
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing; // On WWW, false is used for a new modern build.
140136
var enableProfilerNestedUpdateScheduledHook =
141137
dynamicFeatureFlags.enableProfilerNestedUpdateScheduledHook;

‎compiled/facebook-www/JSXDEVRuntime-dev.modern.js‎

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,6 @@ var disableInputAttributeSyncing =
121121
dynamicFeatureFlags.deferRenderPhaseUpdateToNextBatch,
122122
enableDebugTracing = dynamicFeatureFlags.enableDebugTracing,
123123
skipUnmountedBoundaries = dynamicFeatureFlags.skipUnmountedBoundaries,
124-
createRootStrictEffectsByDefault =
125-
dynamicFeatureFlags.createRootStrictEffectsByDefault,
126124
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
127125
disableNativeComponentFrames =
128126
dynamicFeatureFlags.disableNativeComponentFrames,
@@ -134,8 +132,6 @@ var disableInputAttributeSyncing =
134132
enableUnifiedSyncLane = dynamicFeatureFlags.enableUnifiedSyncLane,
135133
enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay =
136134
dynamicFeatureFlags.enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay,
137-
enableClientRenderFallbackOnTextMismatch =
138-
dynamicFeatureFlags.enableClientRenderFallbackOnTextMismatch,
139135
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing; // On WWW, true is used for a new modern build.
140136
var enableProfilerNestedUpdateScheduledHook =
141137
dynamicFeatureFlags.enableProfilerNestedUpdateScheduledHook;

‎compiled/facebook-www/REVISION‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
fb324faf8a3da08212bcc5ea9e3a084dbfa80dad
1+
7002a6743ebb24ed55af8f626c89dd39460230fc

‎compiled/facebook-www/REVISION_TRANSFORMS‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
fb324faf8a3da08212bcc5ea9e3a084dbfa80dad
1+
7002a6743ebb24ed55af8f626c89dd39460230fc

‎compiled/facebook-www/React-dev.classic.js‎

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ if (
2727
}
2828
"use strict";
2929

30-
var ReactVersion = "18.3.0-www-classic-fb324faf8-20230110";
30+
var ReactVersion = "18.3.0-www-classic-7002a6743-20230110";
3131

3232
// ATTENTION
3333
// When adding new symbols to this file,
@@ -492,8 +492,6 @@ var disableInputAttributeSyncing =
492492
dynamicFeatureFlags.deferRenderPhaseUpdateToNextBatch,
493493
enableDebugTracing = dynamicFeatureFlags.enableDebugTracing,
494494
skipUnmountedBoundaries = dynamicFeatureFlags.skipUnmountedBoundaries,
495-
createRootStrictEffectsByDefault =
496-
dynamicFeatureFlags.createRootStrictEffectsByDefault,
497495
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
498496
disableNativeComponentFrames =
499497
dynamicFeatureFlags.disableNativeComponentFrames,
@@ -505,8 +503,6 @@ var disableInputAttributeSyncing =
505503
enableUnifiedSyncLane = dynamicFeatureFlags.enableUnifiedSyncLane,
506504
enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay =
507505
dynamicFeatureFlags.enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay,
508-
enableClientRenderFallbackOnTextMismatch =
509-
dynamicFeatureFlags.enableClientRenderFallbackOnTextMismatch,
510506
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing; // On WWW, false is used for a new modern build.
511507
var enableProfilerNestedUpdateScheduledHook =
512508
dynamicFeatureFlags.enableProfilerNestedUpdateScheduledHook;

‎compiled/facebook-www/React-dev.modern.js‎

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ if (
2727
}
2828
"use strict";
2929

30-
var ReactVersion = "18.3.0-www-modern-fb324faf8-20230110";
30+
var ReactVersion = "18.3.0-www-modern-7002a6743-20230110";
3131

3232
// ATTENTION
3333
// When adding new symbols to this file,
@@ -492,8 +492,6 @@ var disableInputAttributeSyncing =
492492
dynamicFeatureFlags.deferRenderPhaseUpdateToNextBatch,
493493
enableDebugTracing = dynamicFeatureFlags.enableDebugTracing,
494494
skipUnmountedBoundaries = dynamicFeatureFlags.skipUnmountedBoundaries,
495-
createRootStrictEffectsByDefault =
496-
dynamicFeatureFlags.createRootStrictEffectsByDefault,
497495
enableUseRefAccessWarning = dynamicFeatureFlags.enableUseRefAccessWarning,
498496
disableNativeComponentFrames =
499497
dynamicFeatureFlags.disableNativeComponentFrames,
@@ -505,8 +503,6 @@ var disableInputAttributeSyncing =
505503
enableUnifiedSyncLane = dynamicFeatureFlags.enableUnifiedSyncLane,
506504
enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay =
507505
dynamicFeatureFlags.enableCapturePhaseSelectiveHydrationWithoutDiscreteEventReplay,
508-
enableClientRenderFallbackOnTextMismatch =
509-
dynamicFeatureFlags.enableClientRenderFallbackOnTextMismatch,
510506
enableTransitionTracing = dynamicFeatureFlags.enableTransitionTracing; // On WWW, true is used for a new modern build.
511507
var enableProfilerNestedUpdateScheduledHook =
512508
dynamicFeatureFlags.enableProfilerNestedUpdateScheduledHook;

‎compiled/facebook-www/React-prod.classic.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -643,4 +643,4 @@ exports.useSyncExternalStore = function(
643643
);
644644
};
645645
exports.useTransition = useTransition;
646-
exports.version = "18.3.0-www-classic-fb324faf8-20230110";
646+
exports.version = "18.3.0-www-classic-7002a6743-20230110";

‎compiled/facebook-www/React-prod.modern.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -635,4 +635,4 @@ exports.useSyncExternalStore = function(
635635
);
636636
};
637637
exports.useTransition = useTransition;
638-
exports.version = "18.3.0-www-modern-fb324faf8-20230110";
638+
exports.version = "18.3.0-www-modern-7002a6743-20230110";

‎compiled/facebook-www/React-profiling.classic.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -654,7 +654,7 @@ exports.useSyncExternalStore = function(
654654
);
655655
};
656656
exports.useTransition = useTransition;
657-
exports.version = "18.3.0-www-classic-fb324faf8-20230110";
657+
exports.version = "18.3.0-www-classic-7002a6743-20230110";
658658

659659
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
660660
if (

‎compiled/facebook-www/React-profiling.modern.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -646,7 +646,7 @@ exports.useSyncExternalStore = function(
646646
);
647647
};
648648
exports.useTransition = useTransition;
649-
exports.version = "18.3.0-www-modern-fb324faf8-20230110";
649+
exports.version = "18.3.0-www-modern-7002a6743-20230110";
650650

651651
/* global __REACT_DEVTOOLS_GLOBAL_HOOK__ */
652652
if (

0 commit comments

Comments
 (0)