Skip to content

Commit 91e5c3d

Browse files
fix(devtools): remove duplicated "Display density" field in General settings (#34792)
<!-- Thanks for submitting a pull request! We appreciate you spending the time to work on these changes. Please provide enough information so that others can review your pull request. The three fields below are mandatory. Before submitting a pull request, please make sure the following is done: 1. Fork [the repository](https://github.com/facebook/react) and create your branch from `main`. 2. Run `yarn` in the repository root. 3. If you've fixed a bug or added code that should be tested, add tests! 4. Ensure the test suite passes (`yarn test`). Tip: `yarn test --watch TestName` is helpful in development. 5. Run `yarn test --prod` to test in the production environment. It supports the same options as `yarn test`. 6. If you need a debugger, run `yarn test --debug --watch TestName`, open `chrome://inspect`, and press "Inspect". 7. Format your code with [prettier](https://github.com/prettier/prettier) (`yarn prettier`). 8. Make sure your code lints (`yarn lint`). Tip: `yarn linc` to only check changed files. 9. Run the [Flow](https://flowtype.org/) type checks (`yarn flow`). 10. If you haven't already, complete the CLA. Learn more about contributing: https://reactjs.org/docs/how-to-contribute.html --> ## Summary This pull request fixes a small UI issue in the React Developer Tools settings panel. The “Display density” field was appearing twice in the General tab. Fix : #34791
1 parent 4b3e662 commit 91e5c3d

File tree

1 file changed

+0
-12
lines changed

1 file changed

+0
-12
lines changed

packages/react-devtools-shared/src/devtools/views/Settings/GeneralSettings.js

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -104,18 +104,6 @@ export default function GeneralSettings(_: {}): React.Node {
104104
) : null}
105105
</div>
106106

107-
<div className={styles.SettingWrapper}>
108-
<div className={styles.RadioLabel}>Display density</div>
109-
<select
110-
value={displayDensity}
111-
onChange={({currentTarget}) =>
112-
setDisplayDensity(currentTarget.value)
113-
}>
114-
<option value="compact">Compact</option>
115-
<option value="comfortable">Comfortable</option>
116-
</select>
117-
</div>
118-
119107
{supportsTraceUpdates && (
120108
<div className={styles.SettingWrapper}>
121109
<label className={styles.SettingRow}>

0 commit comments

Comments
 (0)