Check next render works

Author: gaearon

packages/react-dom/src/__tests__/ReactDOMConsoleErrorReporting-test.js

@@ -13,6 +13,7 @@ describe('ReactDOMConsoleErrorReporting', () => {
   let ReactDOM;
 
   let ErrorBoundary;
+  let NoError;
   let container;
   let windowOnError;
 
@@ -34,6 +35,9 @@ describe('ReactDOMConsoleErrorReporting', () => {
         return this.props.children;
       }
     };
+    NoError = function() {
+      return <h1>OK</h1>;
+    };
     container = document.createElement('div');
     document.body.appendChild(container);
     windowOnError = jest.fn();
@@ -125,6 +129,20 @@ describe('ReactDOMConsoleErrorReporting', () => {
           ],
         ]);
       }
+
+      // Check next render doesn't throw.
+      windowOnError.mockReset();
+      console.error.calls.reset();
+      act(() => {
+        ReactDOM.render(<NoError />, container);
+      });
+      expect(container.textContent).toBe('OK');
+      expect(windowOnError.mock.calls).toEqual([]);
+      if (__DEV__) {
+        expect(console.error.calls.all().map(c => c.args)).toEqual([
+          [expect.stringContaining('ReactDOM.render is no longer supported')],
+        ]);
+      }
     });
 
     it('logs render errors without an error boundary', () => {
@@ -178,6 +196,20 @@ describe('ReactDOMConsoleErrorReporting', () => {
           ],
         ]);
       }
+
+      // Check next render doesn't throw.
+      windowOnError.mockReset();
+      console.error.calls.reset();
+      act(() => {
+        ReactDOM.render(<NoError />, container);
+      });
+      expect(container.textContent).toBe('OK');
+      expect(windowOnError.mock.calls).toEqual([]);
+      if (__DEV__) {
+        expect(console.error.calls.all().map(c => c.args)).toEqual([
+          [expect.stringContaining('ReactDOM.render is no longer supported')],
+        ]);
+      }
     });
 
     it('logs render errors with an error boundary', () => {
@@ -234,6 +266,20 @@ describe('ReactDOMConsoleErrorReporting', () => {
           ],
         ]);
       }
+
+      // Check next render doesn't throw.
+      windowOnError.mockReset();
+      console.error.calls.reset();
+      act(() => {
+        ReactDOM.render(<NoError />, container);
+      });
+      expect(container.textContent).toBe('OK');
+      expect(windowOnError.mock.calls).toEqual([]);
+      if (__DEV__) {
+        expect(console.error.calls.all().map(c => c.args)).toEqual([
+          [expect.stringContaining('ReactDOM.render is no longer supported')],
+        ]);
+      }
     });
 
     // TODO: this is broken due to https://github.com/facebook/react/issues/21712.
@@ -291,6 +337,20 @@ describe('ReactDOMConsoleErrorReporting', () => {
           ],
         ]);
       }
+
+      // Check next render doesn't throw.
+      windowOnError.mockReset();
+      console.error.calls.reset();
+      act(() => {
+        ReactDOM.render(<NoError />, container);
+      });
+      expect(container.textContent).toBe('OK');
+      expect(windowOnError.mock.calls).toEqual([]);
+      if (__DEV__) {
+        expect(console.error.calls.all().map(c => c.args)).toEqual([
+          [expect.stringContaining('ReactDOM.render is no longer supported')],
+        ]);
+      }
     });
 
     // TODO: this is broken due to https://github.com/facebook/react/issues/21712.
@@ -351,6 +411,20 @@ describe('ReactDOMConsoleErrorReporting', () => {
           ],
         ]);
       }
+
+      // Check next render doesn't throw.
+      windowOnError.mockReset();
+      console.error.calls.reset();
+      act(() => {
+        ReactDOM.render(<NoError />, container);
+      });
+      expect(container.textContent).toBe('OK');
+      expect(windowOnError.mock.calls).toEqual([]);
+      if (__DEV__) {
+        expect(console.error.calls.all().map(c => c.args)).toEqual([
+          [expect.stringContaining('ReactDOM.render is no longer supported')],
+        ]);
+      }
     });
 
     // TODO: this is broken due to https://github.com/facebook/react/issues/21712.
@@ -408,6 +482,20 @@ describe('ReactDOMConsoleErrorReporting', () => {
           ],
         ]);
       }
+
+      // Check next render doesn't throw.
+      windowOnError.mockReset();
+      console.error.calls.reset();
+      act(() => {
+        ReactDOM.render(<NoError />, container);
+      });
+      expect(container.textContent).toBe('OK');
+      expect(windowOnError.mock.calls).toEqual([]);
+      if (__DEV__) {
+        expect(console.error.calls.all().map(c => c.args)).toEqual([
+          [expect.stringContaining('ReactDOM.render is no longer supported')],
+        ]);
+      }
     });
 
     // TODO: this is broken due to https://github.com/facebook/react/issues/21712.
@@ -468,6 +556,20 @@ describe('ReactDOMConsoleErrorReporting', () => {
           ],
         ]);
       }
+
+      // Check next render doesn't throw.
+      windowOnError.mockReset();
+      console.error.calls.reset();
+      act(() => {
+        ReactDOM.render(<NoError />, container);
+      });
+      expect(container.textContent).toBe('OK');
+      expect(windowOnError.mock.calls).toEqual([]);
+      if (__DEV__) {
+        expect(console.error.calls.all().map(c => c.args)).toEqual([
+          [expect.stringContaining('ReactDOM.render is no longer supported')],
+        ]);
+      }
     });
   });
 });