Commit aeb13ee
committed
Update base for Update on "[compiler] Add fallthrough to branch terminal"
Branch terminals didn't have a fallthrough because they correspond to an outer terminal (optional, logical, etc) that has the "real" fallthrough. But understanding how branch terminals correspond to these outer terminals requires knowing the branch fallthrough. For example, `foo?.bar?.baz` creates terminals along the lines of:
```
bb0:
optional fallthrough=bb4
bb1:
optional fallthrough=bb3
bb2:
...
branch ... (fallthrough=bb3)
...
bb3:
...
branch ... (fallthrough=bb4)
...
bb4:
...
```
Without a fallthrough on `branch` terminals, it's unclear that the optional from bb0 has its branch node in bb3. With the fallthroughs, we can see look for a branch with the same fallthrough as the outer optional terminal to match them up.
[ghstack-poisoned]File tree
18 files changed
+804
-555
lines changed- .github/workflows
- compiler/packages/babel-plugin-react-compiler/src
- Validation
- __tests__/fixtures/compiler
- packages
- react-devtools-extensions/src/main
- react-dom/src/__tests__
- react-reconciler/src/__tests__
- react-server/src
18 files changed
+804
-555
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
87 | 87 | | |
88 | 88 | | |
89 | 89 | | |
90 | | - | |
| 90 | + | |
91 | 91 | | |
92 | 92 | | |
93 | 93 | | |
| |||
0 commit comments